Skip to content

Conversation

@fairlighteth
Copy link
Contributor

Summary

Virtualizes the token search results as outlined in the selector split plan: the “Can’t find your token?” banner now lives inside the scrollable list, rows are rendered through VirtualList, and import sections share the new spacing props so only the visible subset of tokens (or import entries) are hydrated at any time.

To Test

  1. General search flow

    • Open the token selector, type a search term with many matches, and scroll; the banner should stay pinned to the list and rendering should feel smooth.
    • Switch search terms rapidly—verify the list snaps back to the top and doesn’t flash duplicates.
  2. Import sections

    • Search for an address so blockchain/inactive/external sections appear; confirm section headers render once and each block has the expected top/bottom padding.
    • Use the “Import” buttons to ensure IDs/handlers still work.
  3. Bridge context

    • With bridging enabled (pre-filtered tokens), confirm search results still render and virtualization doesn’t break the filtered list.

Background

Part of the ongoing token-selector breakdown, focusing on the search results virtualization and import-section styling tweaks needed before we layer in recents/favorites.

@fairlighteth fairlighteth self-assigned this Nov 13, 2025
@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
cowfi Ready Ready Preview Nov 13, 2025 7:41pm
explorer-dev Ready Ready Preview Nov 13, 2025 7:41pm
sdk-tools Ready Ready Preview Nov 13, 2025 7:41pm
swap-dev Ready Ready Preview Nov 13, 2025 7:41pm
widget-configurator Ready Ready Preview Nov 13, 2025 7:41pm
1 Skipped Deployment
Project Deployment Preview Updated (UTC)
cosmos Ignored Ignored Nov 13, 2025 7:41pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/token-selector-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants