Skip to content

Commit 23911c6

Browse files
committed
Merge branch 'feat/wrapper-base' into feat/wrapper-helpers
2 parents 5877000 + bcda0c2 commit 23911c6

File tree

5 files changed

+25
-86
lines changed

5 files changed

+25
-86
lines changed

.github/pull_request_template.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
## Description
2+
Summarize what this PR does and why in a single, clear sentence.
3+
A reader should understand the purpose and scope of the change just from this line.
4+
5+
## Context
6+
Explain the motivation or problem this PR addresses.
7+
Include links to any relevant documentation, tickets, or discussions.
8+
9+
Provide background that helps reviewers understand *why* the change is needed.
10+
Highlight any important design decisions, dependencies, or related components.
11+
12+
## Out of Scope
13+
Specify what is *not* covered in this PR.
14+
This helps reviewers focus on the intended scope and prevents scope creep.
15+
16+
## Testing Instructions
17+
Provide clear, step-by-step instructions for verifying this change locally.
18+
Assume the reviewer has no prior context about your setup.
19+
20+
This section reinforces the scope of the PR by outlining what should be tested and what the expected outcomes are.

.github/workflows/test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ jobs:
2020

2121
- name: Install Foundry
2222
uses: foundry-rs/foundry-toolchain@v1
23+
with:
24+
version: v1.4.3
2325

2426
- name: Show Forge version
2527
run: |

foundry.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
src = "src"
33
out = "out"
44
libs = ["lib"]
5-
optimize = true
5+
optimizer = true
66

77
# See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options

src/vendor/interfaces/IGPv2Settlement.sol

Lines changed: 0 additions & 84 deletions
This file was deleted.

test/helpers/CowBaseTest.sol

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ import {console} from "forge-std/Test.sol";
2424
contract Solver {
2525
function runBatch(address[] memory targets, bytes[] memory datas) external {
2626
for (uint256 i = 0; i < targets.length; i++) {
27-
targets[i].call(datas[i]);
27+
(bool success,) = targets[i].call(datas[i]);
28+
require(success, "Solver: call failed");
2829
}
2930
}
3031
}

0 commit comments

Comments
 (0)