Merge pull request #9 from cowprotocol/nuno/fix-restart-strategy

Bump versions, make updates forceful and synchronous

Author: naanselmo

Dockerfile

@@ -1,9 +1,9 @@
-FROM node:10-alpine3.10
+FROM node:24-alpine3.22
 
 # Install Kubectl binary
 RUN apk update && \
 apk add --no-cache bash git openssh curl tini && \
-curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.18.5/bin/linux/amd64/kubectl && \
+curl -LO https://dl.k8s.io/release/v1.34.1/bin/linux/amd64/kubectl && \
 chmod +x kubectl && mv kubectl /usr/local/bin/kubectl && \
 rm -rf /var/cache/apk/*
 

routes/images.js

@@ -34,15 +34,15 @@ router.post("/:images/restart", async function (request, response, next) {
 
   // Note: This approach initiates the recreate process in the background after responding to the request.
   // It does not handle concurrency control for multiple overlapping requests.
-  filteredDeployments.forEach(async (deploymentInfo) => {
+  for(const deploymentInfo of filteredDeployments){
     const [deploymentName] = deploymentInfo.split(" ");
     try {
       await deployment.restart(deploymentName);
       debug("Deployment restarted => %s", deploymentName);
     } catch (error) {
-      debug("Error during restart of %s => %s", deploymentName, error.message ? error.message : error);
+      debug("Error during restart of %s => %s", deploymentName, error.message);
     }
-  });
+  }
 });
 
 // Rollout all deployments that run a specific image
@@ -75,15 +75,15 @@ router.post("/:images/rollout", async function (request, response, next) {
 
   // Note: This approach initiates the rollout process in the background after responding to the request.
   // It does not handle concurrency control for multiple overlapping requests.
-  filteredDeployments.forEach(async (deploymentInfo) => {
+  for(const deploymentInfo of filteredDeployments){
     const [deploymentName] = deploymentInfo.split(" ");
     try {
       await deployment.rollout(deploymentName);
       debug("Deployment rolled out => %s", deploymentName);
     } catch (error) {
-      debug("Error during rollout of %s => %s", deploymentName, error.message ? error.message : error);
+      debug("Error during rollout of %s => %s", deploymentName, error.message);
     }
-  });
+  }
 });
 
 module.exports = router;

util/commands.js

@@ -18,6 +18,9 @@ const deployment = {
   replaceConfig (config) {
     return executeCommand('kubectl', ['replace', '-f', '-'], {input: config})
   },
+  forceReplaceConfig (config) {
+    return executeCommand('kubectl', ['replace', '--force', '-f', '-'], {input: config})
+  },
   delete (deploymentName) {
     return executeCommand('kubectl', ['delete', 'deployment', deploymentName])
   },
@@ -45,7 +48,7 @@ const deployment = {
   },
   restart (deploymentName) {
     return this.getConfig(deploymentName).then(config => {
-      return this.replaceConfig(config)
+      return this.forceReplaceConfig(config)
     })
   },
   rollout (deploymentName) {