Migrate get_orders_by_tx endpoint to alloy (#3883)

# Description
Migrate get_orders_by_tx endpoint to alloy

# Changes
<!-- List of detailed changes (how the change is accomplished) -->

- [ ] Migrates the endpoint types to alloy
- [ ] Refactors were applicable

## How to test
Existing tests

<!--
## Related Issues

Fixes #
-->

Author: jmg-duarte

crates/orderbook/src/api/get_orders_by_tx.rs

@@ -1,20 +1,20 @@
 use {
     crate::{api::ApiReply, orderbook::Orderbook},
+    alloy::primitives::B256,
     anyhow::Result,
-    ethcontract::H256,
     reqwest::StatusCode,
     std::{convert::Infallible, sync::Arc},
     warp::{Filter, Rejection, reply::with_status},
 };
 
-pub fn get_orders_by_tx_request() -> impl Filter<Extract = (H256,), Error = Rejection> + Clone {
-    warp::path!("v1" / "transactions" / H256 / "orders").and(warp::get())
+pub fn get_orders_by_tx_request() -> impl Filter<Extract = (B256,), Error = Rejection> + Clone {
+    warp::path!("v1" / "transactions" / B256 / "orders").and(warp::get())
 }
 
 pub fn get_orders_by_tx(
     orderbook: Arc<Orderbook>,
 ) -> impl Filter<Extract = (ApiReply,), Error = Rejection> + Clone {
-    get_orders_by_tx_request().and_then(move |hash: H256| {
+    get_orders_by_tx_request().and_then(move |hash: B256| {
         let orderbook = orderbook.clone();
         async move {
             let result = orderbook.get_orders_for_tx(&hash).await;
@@ -42,6 +42,6 @@ mod tests {
             .filter(&get_orders_by_tx_request())
             .await
             .unwrap();
-        assert_eq!(result.0, H256::from_str(hash_str).unwrap().0);
+        assert_eq!(result.0, B256::from_str(hash_str).unwrap().0);
     }
 }

crates/orderbook/src/database/orders.rs

@@ -1,6 +1,7 @@
 use {
     super::Postgres,
     crate::dto::TokenMetadata,
+    alloy::primitives::B256,
     anyhow::{Context as _, Result},
     app_data::AppDataHash,
     async_trait::async_trait,
@@ -66,7 +67,7 @@ pub trait OrderStoring: Send + Sync {
         old_order: &OrderUid,
         new_order: &Order,
     ) -> Result<(), InsertionError>;
-    async fn orders_for_tx(&self, tx_hash: &H256) -> Result<Vec<Order>>;
+    async fn orders_for_tx(&self, tx_hash: &B256) -> Result<Vec<Order>>;
     /// All orders of a single user ordered by creation date descending (newest
     /// orders first).
     async fn user_orders(
@@ -315,7 +316,7 @@ impl OrderStoring for Postgres {
         .transpose()
     }
 
-    async fn orders_for_tx(&self, tx_hash: &H256) -> Result<Vec<Order>> {
+    async fn orders_for_tx(&self, tx_hash: &B256) -> Result<Vec<Order>> {
         tokio::try_join!(
             self.user_order_for_tx(tx_hash),
             self.jit_orders_for_tx(tx_hash)
@@ -367,7 +368,7 @@ impl OrderStoring for Postgres {
 
 impl Postgres {
     /// Retrieve all user posted orders for a given transaction.
-    pub async fn user_order_for_tx(&self, tx_hash: &H256) -> Result<Vec<Order>> {
+    pub async fn user_order_for_tx(&self, tx_hash: &B256) -> Result<Vec<Order>> {
         let _timer = super::Metrics::get()
             .database_queries
             .with_label_values(&["user_order_for_tx"])
@@ -384,7 +385,7 @@ impl Postgres {
     }
 
     /// Retrieve all JIT orders for a given transaction.
-    pub async fn jit_orders_for_tx(&self, tx_hash: &H256) -> Result<Vec<Order>> {
+    pub async fn jit_orders_for_tx(&self, tx_hash: &B256) -> Result<Vec<Order>> {
         let _timer = super::Metrics::get()
             .database_queries
             .with_label_values(&["jit_orders_for_tx"])

crates/orderbook/src/orderbook.rs

@@ -7,12 +7,12 @@ use {
         dto,
         solver_competition::{Identifier, LoadSolverCompetitionError, SolverCompetitionStoring},
     },
+    alloy::primitives::B256,
     anyhow::{Context, Result},
     app_data::{AppDataHash, Validator},
     bigdecimal::ToPrimitive,
     chrono::Utc,
     database::order_events::OrderEventLabel,
-    ethcontract::H256,
     ethrpc::alloy::conversions::IntoLegacy,
     model::{
         DomainSeparator,
@@ -496,7 +496,7 @@ impl Orderbook {
         self.database_replica.single_order(uid).await
     }
 
-    pub async fn get_orders_for_tx(&self, hash: &H256) -> Result<Vec<Order>> {
+    pub async fn get_orders_for_tx(&self, hash: &B256) -> Result<Vec<Order>> {
         self.database_replica.orders_for_tx(hash).await
     }