Revert "Fetch uncached V3 pools on demand so cold quotes find liquidity (#4560)" (#4629)

# Description
The original PR led to `fetch_liquidity` taking orders of magnitude more
than usual on service restarts. When performing tests this becomes
particularly bad because of the deployment neighboring nature.

<img width="739" height="614" alt="image"
src="https://github.com/user-attachments/assets/3423386a-4199-4009-a353-078919d8980a"
/>

# Changes

* Reverts commit 8cb2626.

## How to test

Tested in prod, notice how the spikes disappear
<img width="1099" height="606" alt="image"
src="https://github.com/user-attachments/assets/9468e91e-b021-4af7-9f16-df02e3237fa7"
/>

Author: jmg-duarte

crates/liquidity-sources/src/uniswap_v3/graph_api.rs

@@ -5,7 +5,7 @@ use {
     crate::{
         json_map,
         subgraph::{ContainsId, SubgraphClient},
-        uniswap_v3::{BlockTarget, V3PoolDataSource},
+        uniswap_v3::V3PoolDataSource,
     },
     alloy::primitives::{Address, U256},
     anyhow::Result,
@@ -168,15 +168,6 @@ impl UniV3SubgraphClient {
             .saturating_sub(MAX_REORG_BLOCK_COUNT))
     }
 
-    /// The subgraph queries by concrete block, so `Latest` resolves to the
-    /// safe head.
-    async fn resolve_block(&self, target: BlockTarget) -> Result<u64> {
-        match target {
-            BlockTarget::Latest => self.get_safe_block().await,
-            BlockTarget::Number(n) => Ok(n),
-        }
-    }
-
     fn all_pools_query(include_ticks_filter: bool) -> String {
         let tick_filter = if include_ticks_filter {
             r#"ticks_: { liquidityNet_not: "0" }"#
@@ -247,8 +238,7 @@ impl UniV3SubgraphClient {
 impl V3PoolDataSource for UniV3SubgraphClient {
     /// The subgraph supports historical queries, so every returned pool is
     /// consistently anchored at `target_block`.
-    async fn get_registered_pools(&self, target_block: BlockTarget) -> Result<RegisteredPools> {
-        let target_block = self.resolve_block(target_block).await?;
+    async fn get_registered_pools(&self, target_block: u64) -> Result<RegisteredPools> {
         let variables = json_map! {
             "block" => target_block,
         };
@@ -268,12 +258,8 @@ impl V3PoolDataSource for UniV3SubgraphClient {
     async fn get_pools_with_ticks_by_ids(
         &self,
         ids: &[Address],
-        target_block: BlockTarget,
+        target_block: u64,
     ) -> Result<PoolsWithTicks> {
-        if ids.is_empty() {
-            return Ok(PoolsWithTicks::default());
-        }
-        let target_block = self.resolve_block(target_block).await?;
         let (pools, ticks) = futures::try_join!(
             self.get_pools_by_pool_ids(ids, target_block),
             self.get_ticks_by_pools_ids(ids, target_block)

crates/liquidity-sources/src/uniswap_v3/mod.rs

@@ -27,29 +27,20 @@ use {
 /// the indexer's actual block can be later than `target_block`.
 #[async_trait]
 pub trait V3PoolDataSource: Send + Sync + 'static {
-    /// Fetch the full set of pools the source knows about as of `target_block`.
-    /// `PoolData::ticks` is always `None` here — callers needing ticks must use
-    /// [`Self::get_pools_with_ticks_by_ids`] separately. The split lets a cheap
-    /// "what pools exist?" lookup skip the expensive tick fetch.
-    async fn get_registered_pools(&self, target_block: BlockTarget) -> Result<RegisteredPools>;
+    /// Fetch the full set of pools the source knows about as of a block at or
+    /// after `target_block`. `PoolData::ticks` is always `None` here — callers
+    /// needing ticks must use [`Self::get_pools_with_ticks_by_ids`] separately.
+    /// The split lets a cheap "what pools exist?" lookup skip the expensive
+    /// tick fetch.
+    async fn get_registered_pools(&self, target_block: u64) -> Result<RegisteredPools>;
 
-    /// Fetch pools + their active ticks for the given pool addresses as of
-    /// `target_block`. The returned `fetched_block_number` is the actual
-    /// snapshot block (`>=` a requested [`BlockTarget::Number`]); callers
-    /// should use it as the event-replay anchor.
+    /// Fetch pools + their active ticks for the given pool addresses as of a
+    /// block at or after `target_block`. The returned `fetched_block_number` is
+    /// the actual snapshot block (`>= target_block`); callers should use it as
+    /// the event-replay anchor.
     async fn get_pools_with_ticks_by_ids(
         &self,
         ids: &[Address],
-        target_block: BlockTarget,
+        target_block: u64,
     ) -> Result<PoolsWithTicks>;
 }
-
-/// Which block a [`V3PoolDataSource`] anchors its snapshot to.
-#[derive(Clone, Copy, Debug)]
-pub enum BlockTarget {
-    /// The latest block the source can serve: the subgraph resolves this to its
-    /// safe head, the indexer serves at-head without waiting.
-    Latest,
-    /// A specific block; the source returns data at or after it.
-    Number(u64),
-}