Revert to jemalloc allocator (#3954)

# Description
This PR makes jemalloc the default memory allocator and simplifies heap
profiling configuration by making it purely runtime-controlled via the
`MALLOC_CONF` environment variable. The reason for switching back to
jemalloc is that with a tuned config, it performs better than mimalloc
and also allows creating memory dumps without redeployments.

# Changes
- **Jemalloc is now the default allocator** (was behind
`jemalloc-profiling` feature).
- **Mimalloc is now optional** via `--features mimalloc-allocator` (was
default).
- All binaries now use jemalloc with built-in heap profiling support by
default.
- Developers can optionally use mimalloc if heap profiling is not needed
or there are problems with the jemalloc allocator.
- Heap profiling is now controlled entirely at runtime via
`MALLOC_CONF=prof:true`
- **Removed** `.github/workflows/deploy-profiling.yaml` (no longer
needed)
- **Updated** `.github/workflows/deploy.yaml` to support optional
`features` parameter
    - Currently supported: `mimalloc-allocator`
- Ready for future features to be added (tokio-console will be another
one)

## How to test
Tested on staging and prod. No issues observed. For some reason, on
mainnet-shadow, when active profiling is enabled, liquidity fetching
performance degrades, unlike in other environments (mainnet-prod,
base-prod).

(cherry picked from commit 7829a13)

Author: squadgazzz

.github/workflows/deploy-profiling.yaml

@@ -4,6 +4,11 @@ on:
     branches: [main]
     tags: [v*]
   workflow_dispatch:
+    inputs:
+      features:
+        description: 'Optional cargo features (currently supported: "mimalloc-allocator")'
+        required: false
+        default: ''
 
 jobs:
   deploy:
@@ -40,6 +45,8 @@ jobs:
           push: true
           tags: ${{ steps.meta_services.outputs.tags }}
           labels: ${{ steps.meta_services.outputs.labels }}
+          build-args: |
+            CARGO_BUILD_FEATURES=${{ github.event.inputs.features && format('--features {0}', github.event.inputs.features) || '' }}
 
       - name: Migration image metadata
         id: meta_migration

.github/workflows/deploy.yaml

@@ -10,10 +10,7 @@ ARG CARGO_BUILD_FEATURES=""
 
 # Install dependencies
 RUN --mount=type=cache,target=/var/cache/apt,sharing=locked apt-get update && \
-    apt-get install -y git libssl-dev pkg-config && \
-    if echo "${CARGO_BUILD_FEATURES}" | grep -q "jemalloc-profiling"; then \
-        apt-get install -y build-essential; \
-    fi
+    apt-get install -y git libssl-dev pkg-config build-essential
 # Install Rust toolchain
 RUN rustup install stable && rustup default stable
 

Cargo.lock

@@ -113,28 +113,22 @@ tokio-console
 
 ## Heap Profiling
 
-All binaries support opt-in heap profiling using jemalloc's profiling capabilities. This allows you to analyze memory usage in production environments without restarting services.
+All binaries use jemalloc as the default memory allocator with built-in heap profiling support. Profiling is enabled at runtime via the `MALLOC_CONF` environment variable, allowing you to analyze memory usage in production environments without recompiling or restarting services.
 
-### Building with Heap Profiling
+**Note:** You can optionally use mimalloc instead of jemalloc by building with `--features mimalloc-allocator`, but this disables heap profiling capability.
 
-Build with the `jemalloc-profiling` feature:
-```bash
-cargo build --release --features jemalloc-profiling
-```
+### Enabling Heap Profiling
 
-Or with Docker:
+To enable heap profiling, run services with the `MALLOC_CONF` environment variable set:
 ```bash
-docker build --build-arg CARGO_BUILD_FEATURES="--features jemalloc-profiling" .
+MALLOC_CONF="prof:true,prof_active:true,lg_prof_sample:22"
 ```
 
-### Generating Heap Dumps
+When profiling is enabled, each binary opens a UNIX socket at `/tmp/heap_dump_<binary_name>.sock`.
 
-When running with the profiling feature enabled, each binary opens a UNIX socket at `/tmp/heap_dump_<binary_name>.sock`. To generate a heap dump, connect to the socket and send the "dump" command:
+### Generating Heap Dumps
 
-**Note:** Services must be run with the `MALLOC_CONF` environment variable set:
-```bash
-MALLOC_CONF="prof:true,prof_active:true,lg_prof_sample:19"
-```
+Connect to the socket and send the "dump" command:
 
 ```bash
 # From Kubernetes

Dockerfile

@@ -11,9 +11,8 @@ anyhow = { workspace = true }
 clap = { workspace = true }
 humantime = { workspace = true }
 observe = { workspace = true }
-mimalloc = { workspace = true }
-tikv-jemallocator = { workspace = true, optional = true }
-jemalloc_pprof = { workspace = true, optional = true }
+mimalloc = { workspace = true, optional = true }
+tikv-jemallocator = { workspace = true }
 model = { workspace = true }
 number = { workspace = true }
 prometheus = { workspace = true }
@@ -30,4 +29,4 @@ warp = { workspace = true }
 workspace = true
 
 [features]
-jemalloc-profiling = ["dep:tikv-jemallocator", "dep:jemalloc_pprof", "observe/jemalloc-profiling"]
+mimalloc-allocator = ["dep:mimalloc"]

README.md

@@ -392,7 +392,7 @@ pub async fn start(args: impl Iterator<Item = String>) {
     );
     observe::tracing::initialize(&obs_config);
     observe::panic_hook::install();
-    #[cfg(all(unix, feature = "jemalloc-profiling"))]
+    #[cfg(unix)]
     observe::heap_dump_handler::spawn_heap_dump_handler();
     observe::metrics::setup_registry(Some("gp_v2_alerter".to_string()), None);
     tracing::info!("running alerter with {:#?}", args);

crates/alerter/Cargo.toml

@@ -1,10 +1,10 @@
-#[cfg(feature = "jemalloc-profiling")]
+#[cfg(feature = "mimalloc-allocator")]
 #[global_allocator]
-static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc;
+static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc;
 
-#[cfg(not(feature = "jemalloc-profiling"))]
+#[cfg(not(feature = "mimalloc-allocator"))]
 #[global_allocator]
-static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc;
+static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc;
 
 #[tokio::main]
 async fn main() {

crates/alerter/src/lib.rs

@@ -39,9 +39,8 @@ humantime = { workspace = true }
 indexmap = { workspace = true }
 itertools = { workspace = true }
 maplit = { workspace = true }
-mimalloc = { workspace = true }
-tikv-jemallocator = { workspace = true, optional = true }
-jemalloc_pprof = { workspace = true, optional = true }
+mimalloc = { workspace = true, optional = true }
+tikv-jemallocator = { workspace = true }
 model = { workspace = true }
 num = { workspace = true }
 number = { workspace = true }
@@ -78,4 +77,4 @@ vergen = { workspace = true, features = ["git", "gitcl"] }
 workspace = true
 
 [features]
-jemalloc-profiling = ["dep:tikv-jemallocator", "dep:jemalloc_pprof", "observe/jemalloc-profiling"]
+mimalloc-allocator = ["dep:mimalloc"]

crates/alerter/src/main.rs

@@ -1,10 +1,10 @@
-#[cfg(feature = "jemalloc-profiling")]
+#[cfg(feature = "mimalloc-allocator")]
 #[global_allocator]
-static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc;
+static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc;
 
-#[cfg(not(feature = "jemalloc-profiling"))]
+#[cfg(not(feature = "mimalloc-allocator"))]
 #[global_allocator]
-static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc;
+static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc;
 
 #[tokio::main]
 async fn main() {