Skip to content

Commit 6624d38

Browse files
authored
Update DB reminder readme (#3765)
Updates the DB reminder message, since currently 2 auctions are running in parallel on each deployment, and this should be taken into account when committing DB-breaking changes.
1 parent 01ff7ab commit 6624d38

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/nitpicks.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
- markdown: |
22
Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).
3-
If creating new tables, update the [tables list](https://github.com/cowprotocol/services/blob/main/crates/database/src/lib.rs#L51-L87).
4-
When adding a new index, consider using `CREATE INDEX CONCURRENTLY` for tables involved in the critical execution path.
3+
* If creating new tables, update the [tables list](https://github.com/cowprotocol/services/blob/main/crates/database/src/lib.rs#L51-L87).
4+
* When adding a new index, consider using `CREATE INDEX CONCURRENTLY` for tables involved in the critical execution path.
5+
* For breaking changes, remember that during rollout k8s starts the new autopilot, runs the Flyway migration, and only then shuts down the old pod. That overlap means the previous version can still be processing requests on the migrated schema, so make it compatible first and ship the breaking DB change in the following release.
56
pathFilter:
67
- "database/sql/**"
78

0 commit comments

Comments
 (0)