You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates the DB reminder message, since currently 2 auctions are running
in parallel on each deployment, and this should be taken into account
when committing DB-breaking changes.
Copy file name to clipboardExpand all lines: .github/nitpicks.yml
+3-2Lines changed: 3 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -1,7 +1,8 @@
1
1
- markdown: |
2
2
Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).
3
-
If creating new tables, update the [tables list](https://github.com/cowprotocol/services/blob/main/crates/database/src/lib.rs#L51-L87).
4
-
When adding a new index, consider using `CREATE INDEX CONCURRENTLY` for tables involved in the critical execution path.
3
+
* If creating new tables, update the [tables list](https://github.com/cowprotocol/services/blob/main/crates/database/src/lib.rs#L51-L87).
4
+
* When adding a new index, consider using `CREATE INDEX CONCURRENTLY` for tables involved in the critical execution path.
5
+
* For breaking changes, remember that during rollout k8s starts the new autopilot, runs the Flyway migration, and only then shuts down the old pod. That overlap means the previous version can still be processing requests on the migrated schema, so make it compatible first and ship the breaking DB change in the following release.
0 commit comments