Skip to content

Commit dbc59cf

Browse files
committed
Redundant loop
1 parent 2487d7d commit dbc59cf

File tree

1 file changed

+14
-20
lines changed

1 file changed

+14
-20
lines changed

crates/observe/src/heap_dump_handler.rs

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -61,28 +61,22 @@ async fn handle_connection(listener: &UnixListener) {
6161
return;
6262
};
6363

64-
loop {
65-
let message = read_line(&mut socket).await;
66-
67-
match message.as_deref() {
68-
Some("") => {
69-
tracing::debug!("client terminated connection");
70-
break;
71-
}
72-
None => {
73-
tracing::warn!("failed to read message from socket");
74-
break;
75-
}
76-
Some("dump") => {
77-
generate_and_stream_dump(&mut socket).await;
78-
break; // Close connection after sending dump
79-
}
80-
Some(unknown) => {
81-
tracing::warn!(?unknown, "unknown command received");
82-
break;
83-
}
64+
let message = read_line(&mut socket).await;
65+
match message.as_deref() {
66+
Some("") => {
67+
tracing::debug!("client terminated connection");
68+
}
69+
None => {
70+
tracing::warn!("failed to read message from socket");
71+
}
72+
Some("dump") => {
73+
generate_and_stream_dump(&mut socket).await;
74+
}
75+
Some(unknown) => {
76+
tracing::warn!(?unknown, "unknown command received");
8477
}
8578
}
79+
// Connection automatically closed when socket is dropped
8680
}
8781

8882
async fn generate_and_stream_dump(socket: &mut UnixStream) {

0 commit comments

Comments
 (0)