-
Notifications
You must be signed in to change notification settings - Fork 152
Open
Labels
blockedThis issue is blocked by some other workThis issue is blocked by some other workgood first issueGood for newcomersGood for newcomerstrack:maintenancemaintenance trackmaintenance track
Description
Background
During high user activity, the latency of v1/get_trades deteriorates. The API call does not support pagination, so it can cause slowdowns if a lot of trades are happening for a particular user.
Details
The OpenAPI spec for GET on v1/trades allows one to specify either an order uid or owner address. The returned results are not paginated and can potentially query a lot of data.
Implement pagination for the v1/get_trades in orderbook.
Acceptance criteria
- Pagination feature implemented and merged
- Tested on production traffic that the API latency spike no longer occurs.
Metadata
Metadata
Assignees
Labels
blockedThis issue is blocked by some other workThis issue is blocked by some other workgood first issueGood for newcomersGood for newcomerstrack:maintenancemaintenance trackmaintenance track