-
Notifications
You must be signed in to change notification settings - Fork 151
Description
Background
It turns out the metrics based bad token detection is too blunt of an instrument when there are complicated EIP 1271 orders in the the system which are buggy. Let's say you have an order trading USDC -> USDT but settling it will always fail because the pre-hook setup step required for the EIP 1271 signature to pass is somehow wrong then attributing the problem with the order to the traded tokens can result in many other legitimate orders to be ignored when they trade either one of those tokens.
Details
Instead the approach should probably be changed to ignore particular orders instead. This avoids the issue where 1 bad order kills many other good orders while still timing out all orders that trade specifically problematic tokens.
Acceptance criteria
Metrics based bad token detection should be adjusted to track and filter out orders by UID instead of the traded tokens.