feat(playground): use the staging GPv2Settlement contract #3899
+2,409
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
just dealing with internal request format issues
on to buy order type and then actually attaching the open position solver
next open position
though somewhat inconsistent
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the playground settings to use the staging GPv2Settlement contract. Include a test script. This is sort of a PoC of using an alternate settlement contract for the staging environment.
For testing purposes I deployed a new setltement contract with an updated salt. The address is
0x99B14b6C733a8E2196d5C561e6B5F6f083F4a7f9.Changes
driver.toml[contracts]section to have the staging settlement contract address.docker-compose.fork.tomlto have environment variables for the settlement contract.test_wrapper.shfrom feat: generalized wrappers #3700 https://github.com/cowprotocol/services/blob/bbd8097feff895394c1f13129b33abc5a80a5e3c/playground/test_wrapper.shHow to test
./playground/test_working.shcast tx <settlement transaction>(requires foundry). Observe that the transactiontois the staging settlement address.