Parallelize post processing DB operations further #3955
+30
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Post processing (i.e. storing a bunch of data in the DB) is on the critical auction path. While it does not increase the latency between building the auction and solvers receiving it it does increase the time between getting all solutions and telling the winner to settle.
Changes
The logic was already split into 2 chunks of concurrent tasks. This PR just merges the chunks into one. The new post-processing time should be
max(all_operations)instead ofmax(chunk1_ops) + max(chunk2_ops).Also 1 of the DB queries used a transaction unnecessarily so I changed that to use a regular connection.
How to test
e2e tests