Merge pull request #179 from cowprotocol/release/2.4.0

* Prevent spaces in token symbols (#169)

* Added description about not using token symbols

* Failing validation if token symbol contains spaces

* Trying to fix validate symbol

* Trying a ternary operator in shell to fix exit value

* Revert "Trying a ternary operator in shell to fix exit value"

This reverts commit 00e6e44.

* Revert "Trying to fix validate symbol"

This reverts commit a7de559.

* Revert "Prevent spaces in token symbols (#169)"

This reverts commit 566a6cd.

* New attempt at validating token symbols

* [addToken] `WETH` to `GNOSIS_CHAIN` (#178)

* [addToken] GNOSIS_CHAIN/0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1

* Reverting to original image

---------

Co-authored-by: alfetopito <[email protected]>

* Bumped version to 2.4.0

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: alfetopito

.github/ISSUE_TEMPLATE/addTokenForm.yml

@@ -30,6 +30,7 @@ body:
     id: symbol
     attributes:
       label: Token Symbol
+      description: The token symbol cannot contain spaces
       placeholder: SYMBOL
     validations:
       required: true

.github/workflows/processRequest.yml

@@ -126,6 +126,12 @@ jobs:
           echo "${{ env.NETWORK }} ${{ env.URL }} ${{ env.ADDRESS }}"
           echo "::error title={Validation failed}::{Missing required fields for adding a token}"
           exit 1
+      - name: Validate symbol
+        if: env.SYMBOL && contains(env.SYMBOL, ' ')
+        run: |
+          echo "${{ env.SYMBOL }}"
+          echo "::error title={Validation failed}::{Symbol cannot contain spaces}" 
+          exit 1
       - name: Validate removeToken
         if: contains(github.event.issue.labels.*.name, 'removeToken') && (!env.NETWORK || !env.REASON || !env.ADDRESS)
         run: |

src/public/CowSwap.json

@@ -1,10 +1,10 @@
 {
   "name": "CoW Swap",
-  "timestamp": "2023-04-18T10:00:00+00:00",
+  "timestamp": "2023-04-18T16:30:00+00:00",
   "version": {
     "major": 2,
-    "minor": 3,
-    "patch": 1
+    "minor": 4,
+    "patch": 0
   },
   "logoURI": "https://ipfs.cow.fi/ipfs/Qme9B6jRpGtZsRFcPjHvA5T4ugFuL4c3SzWfxyMPa59AMo",
   "keywords": [
@@ -644,6 +644,14 @@
       "decimals": 18,
       "chainId": 1,
       "logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0x18084fba666a33d37592fa2633fd49a74dd93a88/logo.png"
+    },
+    {
+      "address": "0x6a023ccd1ff6f2045c3309768ead9e68f978f6e1",
+      "symbol": "WETH",
+      "name": "Wrapped Ether on Gnosis Chain",
+      "decimals": 18,
+      "chainId": 100,
+      "logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/100/0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1/logo.png"
     }
   ]
 }

src/public/images/100/0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1/info.json

@@ -0,0 +1,10 @@
+{
+  "removed": false,
+  "address": "0x6a023ccd1ff6f2045c3309768ead9e68f978f6e1",
+  "symbol": "WETH",
+  "name": "Wrapped Ether on Gnosis Chain",
+  "logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/100/0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1/logo.png",
+  "reason": "We don't have WETH for gnosis chain in our list",
+  "decimals": 18,
+  "chainId": 100
+}