Skip to content

Commit 483f336

Browse files
sblaisotnono
authored andcommitted
Improve swift-layout-v3 migration worker logs (#2136)
1 parent 501c2ae commit 483f336

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

worker/migrations/migrations.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ func migrateToSwiftV3(domain string) error {
8585
return err
8686
}
8787

88+
log := logger.WithDomain(inst.Domain).WithField("nspace", "migration")
89+
8890
var srcContainer, migratedFrom string
8991
switch inst.SwiftLayout {
9092
case 0: // layout v1
@@ -106,6 +108,8 @@ func migrateToSwiftV3(domain string) error {
106108
return instance.ErrInvalidSwiftLayout
107109
}
108110

111+
log.Infof("Migrating from swift layout %s to swift layout v3", migratedFrom)
112+
109113
vfs := inst.VFS()
110114
root, err := vfs.DirByID(consts.RootDirID)
111115
if err != nil {
@@ -125,7 +129,6 @@ func migrateToSwiftV3(domain string) error {
125129
defer func() {
126130
if err != nil {
127131
if err := vfsswift.DeleteContainer(c, dstContainer); err != nil {
128-
log := logger.WithDomain(inst.Domain).WithField("nspace", "migration")
129132
log.Errorf("Failed to delete v3 container %s: %s", dstContainer, err)
130133
}
131134
}
@@ -144,7 +147,9 @@ func migrateToSwiftV3(domain string) error {
144147
if err = couchdb.UpdateDoc(couchdb.GlobalDB, inst); err != nil {
145148
return err
146149
}
147-
_ = vfs.Delete()
150+
if err = vfs.Delete(); err != nil {
151+
log.Errorf("Failed to delete old %s containers: %s", migratedFrom, err)
152+
}
148153
return nil
149154
}
150155

0 commit comments

Comments
 (0)