-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
Hi, I used your IntentHandler code in cozy/cozy-contacts#155 and it worked very well! The new intent handling structure is great!
I just made a few changes to the file but linters fucked up the diff..
- I had to wrap the spinner in a thing that would center it. The
IntentModalin Ui already has a spinner, maybe we could look at how it's done there to avoid the extra element - I used the new
Emptycomponent from UI for the error view. - And I added proptypes because I had too.
I can contribute these changes back to cozy-store but I'm not sure they are too interesting, but if/when we integrate these components in a separate lib, we should keep these things in mind :)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels