Set HT protection mode correctly in mesh_mpm_plink_estab / mesh_mpm_fsm

[silverjam]

Issue by silverjam from Thursday Apr 24, 2014 at 23:45 GMT
Originally opened as cozybit/wpa_s_mesh_android#31

---

In mesh_mpm_plink_estab we had:

       /* TODO
      changed |= mesh_set_ht_op_mode(cand->conf->mesh);
       */

We removed this as part of pushing mesh support upstream, because of a comment from Thomas:

> This is related to setting right HT protection mode, but it really
> belongs in a tracker, not here.

..but we've already have HT support implemented... maybe not completely? Perhaps the HT protection mode is not being setup correctly, according to the HT IEs.

Other references to this follow:
In mesh_mpm_fsm:

         case PLINK_ESTAB:                                                           
         switch (event) {                                                        
         case CLS_ACPT:                                                          
             wpa_mesh_set_plink_state(wpa_s, sta, PLINK_HOLDING);                
             reason = WLAN_REASON_MESH_CLOSE_RCVD;                               

            eloop_register_timeout(dot11MeshHoldingTimeout, 0, plink_timer, wpa_s, sta);
            /* TODO                                                             
            changed |= mesh_set_ht_op_mode(cand->conf->mesh);                   
            */                                                                  
            sta->mpm_close_reason = reason; 

and later in mesh_mpm_fsm:

    default:                                                                    
        wpa_msg(wpa_s, MSG_INFO, "Unsupported MPM event %s for state %s",       
                        mplevent[event], mplstate[sta->plink_state]);               
        break;                                                                  
    }                                                                           
    /* TODO                                                                         
    if (changed)                                                                
        meshd_set_mesh_conf(cand->conf->mesh, changed);
    */