Skip to content

Commit 7f3a726

Browse files
committed
app: drop dead whenever cron line; restore --atomic deploy
The app image has no cron daemon, so whenever --update-crontab was a no-op — the daily sitemap:refresh it installed never ran. The sitemap must live in the serving pod (public_file_server serves /sitemap.xml), so a CronJob is not suitable; the on-boot sitemap:refresh is the correct pattern and is kept. Restore --atomic now that the deploy is healthy (was --wait for inspection).
1 parent 4ce212f commit 7f3a726

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

.docker/scripts/startup-app

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,5 @@ else
1414
fi
1515

1616
bundle exec rails sitemap:refresh:no_ping
17-
bundle exec rails whenever --update-crontab
1817

1918
exec bundle exec rails server -b 0.0.0.0 -p 5000

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,6 +552,6 @@ jobs:
552552
run: |
553553
helm upgrade --install home-server ./infrastructure/helm \
554554
--namespace home-server-production \
555-
--wait --timeout 5m \
555+
--atomic --timeout 5m \
556556
--set app.image.tag=${{ github.sha }} \
557557
--set worker.image.tag=${{ github.sha }}

0 commit comments

Comments
 (0)