Fix: exclude health and root path (#54)

Author: ImJustNon

src/app.module.ts

@@ -88,6 +88,6 @@ import { UtilModule } from "./modules/util/util.module";
 })
 export class AppModule {
 	configure(consumer: MiddlewareConsumer) {
-		consumer.apply(logger).forRoutes("*");
+		consumer.apply(logger).exclude({ path: "/favicon.ico", method: RequestMethod.GET }, { path: "/", method: RequestMethod.GET }, { path: "/health", method: RequestMethod.GET }).forRoutes("*");
 	}
 }

src/common/middlewares/Logger.middleware.ts

@@ -3,7 +3,16 @@ import { DiscordWebhook } from "src/utils/discord-webhook";
 
 const discordWebhook = new DiscordWebhook();
 
+const EXCLUDED_PATHS = ["/health", "/"];
+
 export function logger(req: Request, res: Response, next: NextFunction) {
+	const url = req.originalUrl || req.url;
+
+	// Skip logging for excluded paths
+	if (EXCLUDED_PATHS.includes(url)) {
+		return next();
+	}
+
 	const startTime = Date.now();
 	let responseBody: any = null;
 

src/utils/discord-webhook.ts

@@ -25,6 +25,11 @@ export class DiscordWebhook {
 				return;
 			}
 
+			// Ensure description doesn't exceed Discord's 4096 char limit
+			if (body.description.length > 4096) {
+				body.description = `${body.description.slice(0, 4080)}\n...(truncated)`;
+			}
+
 			await axios.post(config.logging.webhookUrl, {
 				embeds: [body],
 				allowed_mentions: {
@@ -33,15 +38,29 @@ export class DiscordWebhook {
 			});
 
 			this.logger.success("Logging message has been sent!");
-		} catch (e) {
-			this.logger.error(e);
+		} catch (e: any) {
+			const errorData = e?.response?.data ? JSON.stringify(e.response.data) : e?.message || "Unknown error";
+			this.logger.error(`Discord webhook failed: ${errorData}`);
 		}
 	}
 
 	errorEmbed(...ctx: any[]): EmbedMessage {
+		const formatted = ctx
+			.map((item) => {
+				if (item instanceof Error) {
+					return `${item.name}: ${item.message}\n${item.stack || ""}`;
+				}
+				if (typeof item === "object") {
+					return JSON.stringify(item, null, 2);
+				}
+				return String(item);
+			})
+			.join(" ")
+			.slice(0, 4000);
+
 		return {
 			title: "Service Error!!!",
-			description: `\`\`\` ${ctx} \`\`\``,
+			description: `\`\`\`\n${formatted}\n\`\`\``,
 			color: 16711680,
 			footer: {
 				text: "Backend Service | ComCamp 37",