Skip to content

Commit 1013ef0

Browse files
committed
Micro-optimization in prepare_issues_for_diff_report
Also remove outdated comment and alternative code that is no simpler.
1 parent 8a790cf commit 1013ef0

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/lists.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -509,13 +509,9 @@ void prepare_issues(std::span<lwg::issue> issues, lwg::metadata & meta) {
509509

510510
auto prepare_issues_for_diff_report(std::vector<lwg::issue> const & issues) -> std::vector<std::tuple<int, std::string>> {
511511
std::vector<std::tuple<int, std::string>> result;
512+
result.reserve(issues.size());
512513
std::transform( issues.begin(), issues.end(), back_inserter(result),
513-
#if 1
514514
[](lwg::issue const & iss) { return std::make_tuple(iss.num, iss.stat); }
515-
#else
516-
// This form does not work because tuple constructors are explicit
517-
[](lwg::issue const & iss) -> std::tuple<int, std::string> { return {iss.num, iss.stat}; }
518-
#endif
519515
);
520516
return result;
521517
}

0 commit comments

Comments
 (0)