Stale weather data messes up weather graph due to 0 values in hourly data

[DemiImp]

When there's a failed weather update (which almost happens every hour for me) you have an issue where you shift the weather values (copy_len)

However the weather graph always assumes all 24/25 values are available. Some values then become 0. This messed up the graph drawing because now there are 0's in hourly (and pts and apt). You need to pass in the number of valid values (copy_len) to the graph UI and change your for loops to only look at the valid values.

I really need to look into why almost every hour the weather update fails.

[DemiImp]

I think copy_len == hours remaining. If that's true then you need to just fix the hard coded < 25 to be hours remaining

[cr0ybot]

I may be misunderstanding you, but the forecast data is shifted every hour on purpose regardless of whether it includes a full 24 hours of data so that the cached hours continue to line up. I haven't seen values at 0 though, PR #2 was meant to fix that explicitly and instead show a "disconnected" icon. I'm currently working on an update to change how/when weather data is fetched so that it isn't strictly hourly and also includes a set of retries with exponential backoff.

[Chais]

Is there something you or we can do about missing data? Having half a day missing is a little annoying.
I can capture screenshots do the watch is clearly connected to the phone, but without info why the data is missingi can't even begin to diagnose the issue.
Some logs in the settings might be helpful. I could imagine this being a rate limiting issue, so having the option to use a custom API key for the weather backend might help alleviate the issue for everyone.