Fixed complete payment using outdated transaction data

Author: nfourtythree

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Fixed a PHP error that could occur when upgrading to Commerce 5. ([#4077](https://github.com/craftcms/commerce/issues/4077))
 - Fixed a bug where shipping rules weren’t saving their customer conditions correctly. ([#4079](https://github.com/craftcms/commerce/issues/4079))
+- Fixed a bug where outdated transaction data could be used when completing a payment.
 
 ## 5.4.2 - 2025-07-16
 

src/services/Payments.php

@@ -410,6 +410,9 @@ public function completePayment(Transaction $transaction, ?string &$customError)
             throw new Exception('Unable to acquire a lock for transaction: ' . $transaction->hash);
         }
 
+        // Make sure we have the latest transaction data
+        $transaction = Plugin::getInstance()->getTransactions()->getTransactionByHash($transaction->hash);
+
         // If it's successful already, we're good.
         if (Plugin::getInstance()->getTransactions()->isTransactionSuccessful($transaction)) {
             $transaction->order->updateOrderPaidInformation();