#4175 Event once causing multiple table aliases to be added

Author: nfourtythree

CHANGELOG.md

@@ -2,13 +2,15 @@
 
 ## Unreleased
 
+- Added the missing Preview Targets UI to product type settings. ([#4127](https://github.com/craftcms/commerce/issues/4127))
 - Fixed a bug where tax and shipping categories weren't getting saved on the Edit variant screen. ([#4180](https://github.com/craftcms/commerce/issues/4180))
 - Fixed a bug where newly created variants weren’t visible on Edit product screens. 
 - Fixed a SQL error that could occur when viewing product indexes.
 - Fixed a PHP error that occurred when applying project config changes after updating. ([#4185](https://github.com/craftcms/commerce/issues/4185))
 - Fixed a bug where an Order’s origin was set incorrectly when creating an order in the control panel.
-- Added the missing Preview Targets UI to product type settings. ([#4127](https://github.com/craftcms/commerce/issues/4127))
 - Fixed a bug where prices weren’t showing formatted per the user’s formatting locale, in payment modals on Edit Order pages.
+- Fixed a SQL error that could occur when generating the pricing catalog. ([#4175](https://github.com/craftcms/commerce/issues/4175))
+- Added `craft\commerce\models\CatalogPricingRule::afterPreparePurchasableQuery()`.
 
 ## 5.5.0.1 - 2025-11-24
 

src/models/CatalogPricingRule.php

@@ -322,23 +322,16 @@ public function getPurchasableIds(): ?array
                 }
 
                 // We are unable to use `siteId()` on the purchasable query as it is only the subquery part that is used.
-                Event::once(ElementQuery::class, ElementQuery::EVENT_AFTER_PREPARE, function(CancelableEvent $event) use ($siteIds) {
-                    foreach ($event->sender->subQuery->where as &$value) {
-                        if (is_array($value) && isset($value['elements_sites.siteId'])) {
-                            $value['elements_sites.siteId'] = $siteIds;
-                        }
-                    }
-
-                    $event->sender->subQuery->join[] = ['LEFT JOIN', ['sitestores' => Table::SITESTORES], '[[elements_sites.siteId]] = [[sitestores.siteId]]'];
-                    $event->sender->subQuery->join[] = ['LEFT JOIN', ['purchasables_stores' => Table::PURCHASABLES_STORES], '[[purchasables_stores.storeId]] = [[sitestores.storeId]] AND [[purchasables_stores.purchasableId]] = [[elements.id]]'];
-                });
 
                 // If the rule is generating a promotional price, we need to make sure the purchasable is promotable
                 if ($this->isPromotionalPrice) {
                     $purchasableQuery->andWhere(Db::parseBooleanParam('purchasables_stores.promotable', true));
                 }
 
+                // Do this adjustment to the query once (was previously using `Event::once` but this caused issues in some edge cases)
+                $purchasableQuery->on(ElementQuery::EVENT_AFTER_PREPARE, [$this, 'afterPreparePurchasableQuery'], ['siteIds' => $siteIds]);
                 $this->_purchasableIds = $purchasableQuery->ids();
+                $purchasableQuery->off(ElementQuery::EVENT_AFTER_PREPARE, [$this, 'afterPreparePurchasableQuery']);
             }
 
             $this->_purchasableIds = $this->_purchasableIds !== null ? array_unique($this->_purchasableIds) : null;
@@ -347,6 +340,23 @@ public function getPurchasableIds(): ?array
         return $this->_purchasableIds;
     }
 
+    /**
+     * @param CancelableEvent $event
+     * @return void
+     * @since 5.5.1
+     */
+    public function afterPreparePurchasableQuery(CancelableEvent $event): void
+    {
+        foreach ($event->sender->subQuery->where as &$value) {
+            if (is_array($value) && isset($value['elements_sites.siteId'])) {
+                $value['elements_sites.siteId'] = $event->data['siteIds'];
+            }
+        }
+
+        $event->sender->subQuery->join[] = ['LEFT JOIN', ['sitestores' => Table::SITESTORES], '[[elements_sites.siteId]] = [[sitestores.siteId]]'];
+        $event->sender->subQuery->join[] = ['LEFT JOIN', ['purchasables_stores' => Table::PURCHASABLES_STORES], '[[purchasables_stores.storeId]] = [[sitestores.storeId]] AND [[purchasables_stores.purchasableId]] = [[elements.id]]'];
+    }
+
     /**
      * @return ElementConditionInterface
      */