[Error] Attempt to modify property "tags" on null

[GaryReckard]

I'm seeing this error "[Error] Attempt to modify property "tags" on null" show up on my production site that I just upgraded from Craft 3 to Craft 5, when using the element-api and when no results are returned. This doesn't happen locally, haven't figured out why yet, but I did notice when inspecting the code that these lines:

element-api/src/controllers/DefaultController.php

Lines 236 to 237 in 3fbcff8

	[$dep, $maxDuration] = $elementsService->stopCollectingCacheInfo();
	$dep->tags[] = 'element-api';

are going to fail with that error this due to these lines:

        if (empty($tags)) {
            return [null, null];
        }

in
https://github.com/craftcms/cms/blob/00a6febb85972771ca9af8d42abb28c5cd24a40a/src/services/Elements.php#L749-L751

Not sure the best resolution here, but wanted to flag.

[brandonkelly]

Thanks for reporting that! Element API 4.2.0 is out now with a fix.