[PR] PR feedback

Author: LucaKro

.github/workflows/build_and_deploy_doc.yml

@@ -8,7 +8,6 @@ on:
   push:
     branches:
     - main
-    - docker
 
     # If your git repository has the Jupyter Book within some-subfolder next to
     # unrelated files, you can make this run only if a file within that specific

.github/workflows/notebook-test-ci.yml

@@ -4,7 +4,6 @@ on:
   push:
     branches:
       - main
-      - docker
   pull_request:
     branches:
       - main
@@ -19,7 +18,7 @@ defaults:
 jobs:
   test-and-build:
     name: Test Jupyter Notebooks
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     container:
       image: "pycram/semantic_world:jazzy"
 

doc/requirements.txt

@@ -4,4 +4,3 @@ numpy
 sphinx-autoapi
 sphinxcontrib-plantuml
 pylint
-semantic_world

docker/Dockerfile

@@ -10,7 +10,7 @@ WORKDIR $OVERLAY_WS/src
 SHELL ["/bin/bash", "-c"]
 
 RUN apt update && apt install python3.12-venv ros-jazzy-xacro python3-vcstool git ros-dev-tools default-jre graphviz graphviz-dev -y
-RUN vcs import --input https://raw.githubusercontent.com/LucaKro/semantic_world/main/rosinstall/semantic_world-https.rosinstall
+RUN vcs import --input https://raw.githubusercontent.com/cram2/semantic_world/main/rosinstall/semantic_world-https.rosinstall
 RUN source /opt/ros/jazzy/setup.bash && cd $OVERLAY_WS && colcon build --symlink-install
 RUN echo "source $OVERLAY_WS/install/setup.bash" >> ~/.bashrc
 

docker/entrypoint.sh

@@ -1,5 +1,4 @@
-#!/bin/bash
-
+#!/usr/bin/env bash
 set -e
 
 source /opt/ros/overlay_ws/install/setup.bash

resources/urdf/box.urdf

@@ -5,7 +5,7 @@ repositories:
     version: ros-jazzy
   semantic_world:
     type: git
-    url: https://github.com/LucaKro/semantic_world.git
+    url: https://github.com/cram2/semantic_world.git
     version: main
   iai_pr2:
     type: git

rosinstall/semantic_world-https.rosinstall

@@ -5,7 +5,7 @@ repositories:
     version: ros-jazzy
   semantic_world:
     type: git
-    url: git@github.com:LucaKro/semantic_world.git
+    url: git@github.com:cram2/semantic_world.git
     version: main
   iai_pr2:
     type: git