Skip to content

Commit 960f7a1

Browse files
committed
MCP: Update table names
1 parent 189dc74 commit 960f7a1

File tree

4 files changed

+14
-16
lines changed

4 files changed

+14
-16
lines changed

framework/mcp/example_builtin.py

+4-6
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,12 @@ async def run():
4040

4141
# Validate database content.
4242
db = DatabaseAdapter("crate://crate@localhost:4200/")
43-
db.run_sql("CREATE TABLE IF NOT EXISTS public.testdrive (id INT, data TEXT)")
44-
db.run_sql("INSERT INTO public.testdrive (id, data) VALUES (42, 'Hotzenplotz')")
45-
db.refresh_table("public.testdrive")
43+
db.run_sql("CREATE TABLE IF NOT EXISTS public.mcp_builtin (id INT, data TEXT)")
44+
db.run_sql("INSERT INTO public.mcp_builtin (id, data) VALUES (42, 'Hotzenplotz')")
45+
db.refresh_table("public.mcp_builtin")
4646

4747
# Read a few resources.
48-
# FIXME: Only works on schema=public, because the PostgreSQL adapter hard-codes `WHERE table_schema = 'public'`.
49-
# https://github.com/bytebase/dbhub/blob/09424c8513c8c7bef7f66377b46a2b93a69a57d2/src/connectors/postgres/index.ts#L89-L107
50-
await client.read_resource("postgres://crate@localhost:5432/testdrive/schema")
48+
await client.read_resource("postgres://crate@localhost:5432/mcp_builtin/schema")
5149

5250

5351
if __name__ == "__main__":

framework/mcp/example_dbhub.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ async def run():
4343

4444
# Validate database content.
4545
db = DatabaseAdapter("crate://crate@localhost:4200/")
46-
db.run_sql("CREATE TABLE IF NOT EXISTS testdrive.dbhub (id INT, data TEXT)")
47-
db.run_sql("INSERT INTO testdrive.dbhub (id, data) VALUES (42, 'Hotzenplotz')")
48-
db.refresh_table("public.testdrive")
46+
db.run_sql("CREATE TABLE IF NOT EXISTS testdrive.mcp_dbhub (id INT, data TEXT)")
47+
db.run_sql("INSERT INTO testdrive.mcp_dbhub (id, data) VALUES (42, 'Hotzenplotz')")
48+
db.refresh_table("testdrive.mcp_dbhub")
4949

5050
# Read available resources.
5151
await client.read_resource("db://schemas")
@@ -57,7 +57,7 @@ async def run():
5757
"schema": "sys",
5858
})
5959
await client.get_prompt("explain_db", arguments={"schema": "testdrive"})
60-
await client.get_prompt("explain_db", arguments={"schema": "testdrive", "table": "dbhub"})
60+
await client.get_prompt("explain_db", arguments={"schema": "testdrive", "table": "mcp_dbhub"})
6161

6262

6363
if __name__ == "__main__":

framework/mcp/example_jdbc.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ async def run():
4242
# await client.call_tool("list_tables", arguments={})
4343
await client.call_tool("describe_table", arguments={"schema": "sys", "table": "summits"})
4444
await client.call_tool("read_query", arguments={"query": "SELECT * FROM sys.summits ORDER BY height DESC LIMIT 3"})
45-
await client.call_tool("create_table", arguments={"query": "CREATE TABLE IF NOT EXISTS testdrive (id INT, data TEXT)"})
46-
await client.call_tool("write_query", arguments={"query": "INSERT INTO testdrive (id, data) VALUES (42, 'foobar')"})
45+
await client.call_tool("create_table", arguments={"query": "CREATE TABLE IF NOT EXISTS testdrive.mcp_jdbc (id INT, data TEXT)"})
46+
await client.call_tool("write_query", arguments={"query": "INSERT INTO testdrive.mcp_jdbc (id, data) VALUES (42, 'foobar')"})
4747

4848
# Get a few prompts.
4949
await client.get_prompt("er_diagram")

framework/mcp/test.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def test_builtin():
4646
# Validate output specific to CrateDB.
4747
assert b"Calling tool: query" in p.stdout
4848
assert b"mountain: Mont Blanc" in p.stdout
49-
assert b"Reading resource: postgres://crate@localhost:5432/testdrive/schema" in p.stdout
49+
assert b"Reading resource: postgres://crate@localhost:5432/mcp_builtin/schema" in p.stdout
5050
assert b"column_name: id" in p.stdout
5151
assert b"data_type: integer" in p.stdout
5252

@@ -77,8 +77,8 @@ def test_jdbc():
7777

7878
# Validate database content.
7979
db = DatabaseAdapter("crate://crate@localhost:4200/")
80-
db.refresh_table("doc.testdrive")
81-
records = db.run_sql("SELECT * FROM doc.testdrive", records=True)
80+
db.refresh_table("testdrive.mcp_jdbc")
81+
records = db.run_sql("SELECT * FROM testdrive.mcp_jdbc", records=True)
8282
assert len(records) >= 1
8383
assert records[0] == {"id": 42, "data": "foobar"}
8484

@@ -114,5 +114,5 @@ def test_dbhub():
114114
assert b"- testdrive" in p.stdout
115115

116116
assert b"Getting prompt: explain_db" in p.stdout
117-
assert b"Table: dbhub in schema 'testdrive'" in p.stdout
117+
assert b"Table: mcp_dbhub in schema 'testdrive'" in p.stdout
118118
assert b"Structure:\\n- id (integer)\\n- data (text)" in p.stdout

0 commit comments

Comments
 (0)