Support guidelines

• I've read the support guidelines

I've found a bug and checked that ...

• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem

Description

The documentation for the recycle option in the Samba Docker image suggests that setting recycle: yes enables the Windows-like recycle bin feature. However, there is no information about how to explicitly disable this feature. If a user sets recycle: no, the implementation does not disable the recycle bin. Instead, the code only checks if the option is not null, so any value other than null (including "no") will still enable the recycle feature. This is confusing and does not match user expectations.

Expected behaviour

Setting recycle: no in the configuration should disable the recycle bin feature for that share.

The documentation should clearly state which values are accepted for the recycle option and what they do.

Actual behaviour

Any value other than null (including "no") enables the recycle bin feature.

There is no documentation warning about this behavior.

Steps to reproduce

1. In /data/config.yml, configure a share with recycle: no.
2. Start the container.
3. Observe that the recycle bin feature is still enabled.

Docker info

-

Docker Compose config

-

Logs

-

Additional info

Proposed solutions

Documentation: Update the documentation to clarify that only omitting the recycle option or setting it to null disables the feature, and that recycle: no is not supported.

Implementation: Change the implementation to explicitly check for recycle: yes to enable the feature, and treat recycle: no (or any value other than yes) as disabling it. This would align with user expectations and common configuration patterns.