Skip to content

Commit d218b2f

Browse files
authored
fix(ci): EVENTS_ARGS may contain additional curl args (tempoxyz#3703)
this PR properly handles `EVENT_ARGS`, which may contain additional curl args successful run with the patch: https://github.com/tempoxyz/tempo/actions/runs/24830269128/job/72676687042
1 parent ce28e4f commit d218b2f

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/docker.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ jobs:
199199
env:
200200
EVENTS_KEY: ${{ secrets.EVENTS_KEY }}
201201
EVENTS_CERT: ${{ secrets.EVENTS_CERT }}
202-
EVENTS_ARGS: ${{ secrets.EVENTS_ARGS }}
203202
RUNNER_TEMP: ${{ runner.temp }}
204203
GH_REPO: ${{ github.repository }}
205204
SHORT_SHA: ${{ steps.shortsha.outputs.shortsha }}
@@ -211,7 +210,8 @@ jobs:
211210
echo "$EVENTS_KEY" > "${RUNNER_TEMP}/key"
212211
echo "$EVENTS_CERT" > "${RUNNER_TEMP}/cert"
213212
214-
curl -sf -o /dev/null -X POST ${EVENTS_ARGS} \
213+
# EVENTS_ARGS may contain additional curl arguments, not just a URL.
214+
curl -sf -o /dev/null -X POST ${{ secrets.EVENTS_ARGS }} \
215215
--key "${RUNNER_TEMP}/key" \
216216
--cert "${RUNNER_TEMP}/cert" \
217217
-H "Content-Type: application/json" \
@@ -231,7 +231,6 @@ jobs:
231231
env:
232232
EVENTS_KEY: ${{ secrets.EVENTS_KEY }}
233233
EVENTS_CERT: ${{ secrets.EVENTS_CERT }}
234-
EVENTS_ARGS: ${{ secrets.EVENTS_ARGS }}
235234
RUNNER_TEMP: ${{ runner.temp }}
236235
GH_REPO: ${{ github.repository }}
237236
COMMIT_SHA: ${{ github.sha }}
@@ -242,7 +241,8 @@ jobs:
242241
echo "$EVENTS_KEY" > "${RUNNER_TEMP}/key"
243242
echo "$EVENTS_CERT" > "${RUNNER_TEMP}/cert"
244243
245-
curl -sf -o /dev/null -X POST ${EVENTS_ARGS} \
244+
# EVENTS_ARGS may contain additional curl arguments, not just a URL.
245+
curl -sf -o /dev/null -X POST ${{ secrets.EVENTS_ARGS }} \
246246
--key "${RUNNER_TEMP}/key" \
247247
--cert "${RUNNER_TEMP}/cert" \
248248
-H "Content-Type: application/json" \

0 commit comments

Comments
 (0)