Skip to content

Limit the number and size of entries #14

Open
@guillaumerose

Description

One attacker could possibly call the admin-helper to add a large number of host files entries or very long DNS names.
We should do something for that.

original comment: crc-org/crc#1793 (comment)

Hmm, any process in the VM can fill the host root filesystem, and maybe slow down name resolution? (dunno if huge /etc/hosts has a noticeable impact on name resolution). I did not check the admin-helper code, but we can limit the number of aliases we add to a few hundreds, and also limit their individual size (which is done already I think), which would address this concern.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions