fix: do not let voiding promises

Signed-off-by: Denis Golovin <[email protected]>
crc-org · Aug 13, 2024 · 0f4cb6a · 0f4cb6a
1 parent e1eaa5b
commit 0f4cb6a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -34,7 +34,7 @@
     "@typescript-eslint/no-var-requires": "off",
     "@typescript-eslint/consistent-type-imports": "error",
     "@typescript-eslint/no-explicit-any": "error",
-    "@typescript-eslint/no-floating-promises": "error",
+    "@typescript-eslint/no-floating-promises": ["error", {"ignoreVoid": false}],
 
   /**
    * Having a semicolon helps the optimizer interpret your code correctly.

diff --git a/src/crc-setup.ts b/src/crc-setup.ts
@@ -92,7 +92,7 @@ export async function setUpCrc(logger: extensionApi.Logger, askForPreset = false
     setupBar.text = 'All done.';
   } catch (err) {
     console.error(err);
-    void extensionApi.window.showErrorMessage(`${productName} configuration failed:\n${err}`);
+    await extensionApi.window.showErrorMessage(`${productName} configuration failed:\n${err}`);
     return false;
   } finally {
     setupBar.hide();

diff --git a/src/crc-start.ts b/src/crc-start.ts
@@ -65,7 +65,7 @@ export async function startCrc(
       return true;
     } else {
       provider.updateStatus('error');
-      void extensionApi.window.showErrorMessage(`Error during starting ${productName}: ${result.Status}`);
+      await extensionApi.window.showErrorMessage(`Error during starting ${productName}: ${result.Status}`);
     }
   } catch (err) {
     if (typeof err.message === 'string') {
@@ -84,7 +84,7 @@ export async function startCrc(
         return true;
       }
     }
-    void extensionApi.window.showErrorMessage(`${productName} start error: ${err}`);
+    await extensionApi.window.showErrorMessage(`${productName} start error: ${err}`);
     console.error(err);
     provider.updateStatus('stopped');
   }
@@ -137,7 +137,7 @@ async function askAndStorePullSecret(logger: extensionApi.Logger): Promise<boole
     }
   } catch (err) {
     // not valid json
-    void extensionApi.window.showErrorMessage(`Start failed, pull secret is not valid. Please start again:\n '${err}'`);
+    await extensionApi.window.showErrorMessage(`Start failed, pull secret is not valid. Please start again:\n '${err}'`);
     return false;
   }
   try {

diff --git a/src/extension.ts b/src/extension.ts
@@ -418,7 +418,7 @@ async function presetChanged(
 
   if (preset === 'podman') {
     // do nothing
-    void extensionApi.window.showInformationMessage(
+    await extensionApi.window.showInformationMessage(
       'Currently we do not support the Podman preset of OpenShift Local. Please use preference to change this:\n\nSettings > Preferences > Red Hat OpenShift Local > Preset',
       'OK',
     );

diff --git a/src/preferences.ts b/src/preferences.ts
@@ -136,7 +136,7 @@ async function handleProxyChange(proxy?: extensionApi.ProxySettings): Promise<vo
     }
   } catch (err) {
     console.error(err);
-    void extensionApi.window.showErrorMessage(`Could not update ${productName} proxy configuration: ${err}`);
+    await extensionApi.window.showErrorMessage(`Could not update ${productName} proxy configuration: ${err}`);
   }
 }
 
@@ -164,7 +164,7 @@ async function configChanged(
       if (element.validation) {
         const validationResult = element.validation(newValue, currentConfig.preset);
         if (validationResult) {
-          void extensionApi.window.showErrorMessage(validationResult);
+          await extensionApi.window.showErrorMessage(validationResult);
           await extConfig.update(key, currentConfig[element.name]);
           continue;
         }