From 80ae5e9ddf4f22742626dcb6541730b20856a575 Mon Sep 17 00:00:00 2001 From: Adrian Riobo Lorenzo Date: Wed, 10 Apr 2024 10:09:44 +0200 Subject: [PATCH 1/2] chore: run crc installer with full user experience previously the installer was executed as a hidden process and did not show any option to reboot the computer even when it was required. Then the flow keep processing and the setup ended up on an error due to not being able to stop it or to reboot the computer. Also this change makes the openshift local installer matches how other installers are executed showing full experience to the user (i.e. podman installer) Signed-off-by: Adrian Riobo Lorenzo --- src/install/win-install.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/install/win-install.ts b/src/install/win-install.ts index 0f0a854..78702aa 100644 --- a/src/install/win-install.ts +++ b/src/install/win-install.ts @@ -41,7 +41,7 @@ export class WinInstall extends BaseInstaller { msiPath = await this.extractMsiFromZip(setupPath); progress.report({ increment: 10 }); - const runResult = await runCliCommand('msiexec.exe', ['/i', msiPath, '/qr', '/norestart']); + const runResult = await runCliCommand('msiexec.exe', ['/i', msiPath, '/qf']); if (runResult.exitCode !== 0) { // installed successfully, but reboot required if (runResult.exitCode === 3010) { From 1c3864aee4e1e1ced9aba9b8b6fcacab7d411421 Mon Sep 17 00:00:00 2001 From: Adrian Riobo Lorenzo Date: Wed, 10 Apr 2024 10:24:11 +0200 Subject: [PATCH 2/2] chore: ask for preset on initialize crc previously the installation flow for crc will include the ask for preset popup, which would end up setting the preset on crc config, as now the installation process typically will end up on a reboot we need to ask / recommend the preset when the initialization button is shown after reboot Signed-off-by: Adrian Riobo Lorenzo --- src/extension.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/extension.ts b/src/extension.ts index 798b298..17bcc72 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -289,7 +289,7 @@ async function initializeCrc( telemetryLogger: extensionApi.TelemetryLogger, logger: extensionApi.Logger, ): Promise { - const hasSetupFinished = await setUpCrc(logger, false); + const hasSetupFinished = await setUpCrc(logger, true); if (hasSetupFinished) { await needSetup(); await connectToCrc();