fix (daemon) : Add docker.internal entry to virtual network DNS config (#3784)
#4601
Conversation
|
Skipping CI for Draft Pull Request. |
rohanKanojia
force-pushed
the
pr/issue3784
branch
from
c17e7a1 to
9535642
Compare
cmd/crc/cmd/daemon.go
Outdated
| }, | ||
| virtualNetworkConfig.NAT[hostVirtualIP] = "127.0.0.1" | ||
| } | ||
| virtualNetworkConfig.GatewayVirtualIPs = []string{hostVirtualIP} |
There was a problem hiding this comment.
Minor comment, I think GatewayVirtualIPs initialisation could be moved in to struct initialisation, it will slightly improve this code.
There was a problem hiding this comment.
Thanks for your suggestion! I've moved it to struct initialization block.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evidolob The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
crc-org#3784) Add `docker.internal` entry to virtual network config DNS records. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/issue3784
branch
from
9535642 to
7cca461
Compare
|
New changes are detected. LGTM label has been removed. |
|
@rohanKanojia: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Fixes: #3784
Port of containers/gvisor-tap-vsock#251 to add
docker.internal.DNS record to CRC daemon virtual network config.Relates to: PR containers/gvisor-tap-vsock#251
Type of change
test, version modification, documentation, etc.)
Proposed changes
docker.internal.Testing
I've only verified it using a unit test.
Contribution Checklist