Determine pending or required reboot on Windows during preflight on Windows

[cfergeau]

During crc setup, if hyperv needs to be installed, the system will need to be rebooted (as this is when hyperv gets enabled/installed). Similarly, the user will need to log out/log in for group membership to take effect.
At the moment, during the preflights, even if these checks/fixes returned errors, we keep going and try to figure out which switch is being used by hyperv, which requires hyperv to be installed/the user to be part of the hyperv admin group, so it will be failing.
What I'd expect instead is:

1. run hyperv installation preflight check/fix
2. run group membership preflight check/fix
   3.1) if any of these 2 failed, instruct the user that they will need to reboot and to run crc setup again
   3.2) if they both succeeded, run the other preflight checks/fixes (at the moment, the only other check is the hyperv network switch one).

Ideally, for 1 and 2, we'd be able to differentiate between "error which will be fixed by a reboot" and "unrelated error", we don't have that level of detail right now
And ideally, for 3.1), we'd be able to ask the user if they want to reboot now, and to resume crc setup ourselves after the reboot.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gbraad]

We can not really determine well if a reboot is needed; since when the suggested install fails (which we can not really detect properly) a reboot is not likely to help much.

we need a better mechanism for this, but are dependent on the RunAsAdmin :-/

[gbraad]

One of the solutions might include checking:

HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Component Based Servicing\RebootPending

or

HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update\RebootRequired

[gbraad]

See:

• https://www.powershellgallery.com/packages/PSSystemInfo/1.0.3
• and a script called Get-PendingReboot