Skip to content

Commit 35d08f8

Browse files
committed
gha: Use 'oldstable' as the go version
Getting the go version from the go.mod file is nice in theory, but has a number of caveats: - we are not always pro-active in updating it, so we could be using an old unsupported version in CI - if the version in go.mod is older than the version in tools/go.mod, there can be issues when trying to build golangci-lint - this does not interact nicely with recent changes in go.mod and the introduction of the toolchain directive, as we are now specifying the minor go version (1.22.0) in go.mod, but we want to build with the latest released 1.22 go version. For all these reasons, this commit switches back to using `oldstable` as the go version to build with instead of getting it from go.mod `oldstable` currently points at 1.23, see https://github.com/actions/setup-go?tab=readme-ov-file#using-stableoldstable-aliases for a longer explanation. Signed-off-by: Christophe Fergeau <[email protected]>
1 parent 3694a7d commit 35d08f8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/macadam.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
- name: Set up Go
5353
uses: actions/setup-go@v5
5454
with:
55-
go-version-file: 'go.mod'
55+
go-version: 'oldstable'
5656
- name: Test
5757
run: make test
5858
lint:
@@ -66,6 +66,6 @@ jobs:
6666
- name: Set up Go
6767
uses: actions/setup-go@v5
6868
with:
69-
go-version-file: 'go.mod'
69+
go-version: 'oldstable'
7070
- name: Run 'make check'
7171
run: make check

0 commit comments

Comments
 (0)