fix local path file name

lstocchi · lstocchi · commit 4d298b51e1ff · 2025-02-27T12:52:39.000+01:00
it fixes how the local path is generated in the noop image puller.
Before the name ended up having 2 dots &lt;name&gt;..raw

Signed-off-by: Luca Stocchi &lt;lstocchi@redhat.com&gt;
diff --git a/pkg/imagepullers/noop.go b/pkg/imagepullers/noop.go
@@ -33,7 +33,7 @@ func (puller *NoopImagePuller) SetSourceURI(sourcePath string) {
 
 func imageExtension(sourceURI string) string {
 	if strings.HasSuffix(sourceURI, ".tar.gz") {
-		return "tar.gz"
+		return ".tar.gz"
 	}
 	return filepath.Ext(sourceURI)
 }
@@ -50,7 +50,7 @@ func (puller *NoopImagePuller) LocalPath() (*define.VMFile, error) {
 		return nil, err
 	}
 
-	vmFile, err := dirs.DataDir.AppendToNewVMFile(fmt.Sprintf("%s-%s.%s", puller.machineName, puller.vmType.String(), imageExtension(puller.sourceURI)), nil)
+	vmFile, err := dirs.DataDir.AppendToNewVMFile(fmt.Sprintf("%s-%s%s", puller.machineName, puller.vmType.String(), imageExtension(puller.sourceURI)), nil)
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func (puller *NoopImagePuller) SetSourceURI(sourcePath string) {`
`33`	`33`
`34`	`34`	`func imageExtension(sourceURI string) string {`
`35`	`35`	`if strings.HasSuffix(sourceURI, ".tar.gz") {`
`36`		`- return "tar.gz"`
	`36`	`+ return ".tar.gz"`
`37`	`37`	`}`
`38`	`38`	`return filepath.Ext(sourceURI)`
`39`	`39`	`}`
`@@ -50,7 +50,7 @@ func (puller NoopImagePuller) LocalPath() (define.VMFile, error) {`
`50`	`50`	`return nil, err`
`51`	`51`	`}`
`52`	`52`
`53`		`- vmFile, err := dirs.DataDir.AppendToNewVMFile(fmt.Sprintf("%s-%s.%s", puller.machineName, puller.vmType.String(), imageExtension(puller.sourceURI)), nil)`
	`53`	`+ vmFile, err := dirs.DataDir.AppendToNewVMFile(fmt.Sprintf("%s-%s%s", puller.machineName, puller.vmType.String(), imageExtension(puller.sourceURI)), nil)`
`54`	`54`	`if err != nil {`
`55`	`55`	`return nil, err`
`56`	`56`	`}`