Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Remove the use of the pull-secret file? #120

Open
@gbraad

Description

It seems the macOS app has a mixed usecase for an entered pull-secret on start and a pull-secret file from the settings? This might lead to confusion around the precedence and actual need. See:

https://github.com/code-ready/tray-macos/blob/007e3c872462cc5dded60b638d2bef7a84b6704d/CodeReady%20Containers/config/ConfigViewController.swift#L135-L138

It might be better to read the contents and then overwrite what is stored in secure storage. See related discussion here: crc-org/crc#2571 about the mixed use of the pull secret in store and the file path.

Note: for Windows I have proposed to remove the file option: crc-org/tray-windows#102

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions