Support Windows through `conpty`

[hinshun]

Windows 10 gained support for psuedo-terminals with conpty: https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/

Prior art:

• node-pty: https://github.com/nodejs/node/blob/b3189266347fa05395860f9f6e8949e447977284/test/pseudo-tty/pty_helper.py
• neovim: win/Terminal: Change to use ConPTY, if available neovim/neovim#11390

Would you be open to a PR?

[creack]

Having windows support would be great. PRs are welcome indeed :)

On Thu, Apr 30, 2020 at 1:29 AM Edgar Lee ***@***.***> wrote: Windows 10 gained support for psuedo-terminals with conpty: https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/ Prior art: - node-pty: https://github.com/nodejs/node/blob/b3189266347fa05395860f9f6e8949e447977284/test/pseudo-tty/pty_helper.py - neovim: neovim/neovim#11390 <neovim/neovim#11390> Would you be open to a PR? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#95>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD7LZNURJEB7ZAQFBT77DLRPEEDXANCNFSM4MVF3YSA> .

-- -- Guillaume J. Charmes Software Engineer https://blog.charmes.net [image: Guillaume J. Charmes on about.me] <https://blog.charmes.net>

[prabirshrestha]

Another option would be to use go-winpty but is based of winpty.dll.

You can also look at the source of portable-pty from rust that supports both winpty and conpty.

[virtuald]

I noted in #50 that https://github.com/containerd/console has a console implementation for Windows. There's quite a bit of overlap with this library -- so it might be worth borrowing from that if someone were to open a PR.

[liuhaowen478]

Any update on this? Would be so great to see this happen

[mardukbp]

ActiveState implemented a Go library for conpty: termtest/conpty

[creack]

@mardukbp unfortunatelly termtest/conpty is based on CGO, which is not an option here as it would be a breaking change. We could consider it for a v2 though.

@virtuald This looks interesting indeed, but as I have 0 experience with windows, I have no idea what's going on there.. If someone want to create a PR, I'd be happy to bring it in, but I don't think I'll have time to do it myself anytime soon.

@liuhaowen478 We are looking for motived people to contribute :)

[mardukbp]

@creack How do you know that termtest/conpty is based on CGO? As far as I can tell, it uses the syscall and windows go packages. I could not find any reference to cgo in the code.

[creack]

As I have no experience with windows, I might be wrong and I didn't test it, but I saw this: https://github.com/ActiveState/termtest/blob/master/conpty/syscall_windows.go#L16

AFAIK, loading a plugin in go requires cgo (golang/go#19569)

[AlbinoDrought]

For what it's worth, here's what I get on a Windows machine:

User@Desktop MINGW64 ~/go/src
$ CGO_ENABLED=0 go get github.com/ActiveState/termtest

User@Desktop MINGW64 ~/go/src
$ cd github.com/ActiveState/termtest/conpty/cmd/example

User@Desktop MINGW64 ~/go/src/github.com/ActiveState/termtest/conpty/cmd/example (master)
$ CGO_ENABLED=0 go build

User@Desktop MINGW64 ~/go/src/github.com/ActiveState/termtest/conpty/cmd/example (master)
$ ./example.exe
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Try the new cross-platform PowerShell https://aka.ms/pscore6

PS C:\Users\User\Downloads> echo "hello world"
hello world
PS C:\Users\User\Downloads>
exit code was: 0

[mardukbp]

According to the Go Wiki loading a DLL with syscall does not require cgo.

AFAIK, loading a plugin in go requires cgo (golang/go#19569)

Yes, but termtest/conpty does not use go plugins.

I think this library is good to go! 😉

Hi @creack , I have opened a pull request for windows conpty support (#109 ), but as noted as known issues there, I probably need some guidance to solve these issues since I am not a windows expert, any idea?