Skip to content

Commit 86e5255

Browse files
committed
ENH Add tabindex prop
1 parent 98d662c commit 86e5255

4 files changed

Lines changed: 8 additions & 3 deletions

File tree

client/dist/js/bundle.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/src/components/LinkField/LinkField.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ const LinkField = ({
6262
ownerRelation,
6363
excludeLinkTextField = false,
6464
inHistoryViewer,
65+
tabIndex = 0,
6566
}) => {
6667
const [data, setData] = useState({});
6768
const [editingID, setEditingID] = useState(0);
@@ -537,7 +538,8 @@ const LinkField = ({
537538
actions,
538539
loading,
539540
excludeLinkTextField,
540-
inHistoryViewer
541+
inHistoryViewer,
542+
tabIndex,
541543
}}>
542544
<div className="link-field__container">
543545
{ renderLoadingError && <div className="link-field__loading-error">{loadingErrorText}</div> }
@@ -582,6 +584,7 @@ LinkField.propTypes = {
582584
ownerRelation: PropTypes.string.isRequired,
583585
excludeLinkTextField: PropTypes.bool,
584586
inHistoryViewer: PropTypes.bool,
587+
tabIndex: PropTypes.number,
585588
};
586589

587590
// redux actions loaded into props - used to get toast notifications

client/src/components/LinkField/tests/LinkField-test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ function makeProps(obj = {}) {
5454
ownerID: 123,
5555
ownerClass: 'Page',
5656
ownerRelation: 'MyRelation',
57+
tabIndex: 0,
5758
...obj
5859
};
5960
}

client/src/components/LinkPicker/LinkPickerMenu.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import LinkType from 'types/LinkType';
99
const LinkPickerMenu = ({ types, onSelect, dropdownToggleRef }) => {
1010
const [isOpen, setIsOpen] = useState(false);
1111
const toggle = () => setIsOpen(prevState => !prevState);
12-
const { loading } = useContext(LinkFieldContext);
12+
const { loading, tabIndex } = useContext(LinkFieldContext);
1313
const ariaLabel = i18n._t('LinkField.ADD_LINK', 'Add link');
1414

1515
return <Dropdown
@@ -24,6 +24,7 @@ const LinkPickerMenu = ({ types, onSelect, dropdownToggleRef }) => {
2424
color="secondary"
2525
aria-label={ariaLabel}
2626
innerRef={dropdownToggleRef}
27+
tabIndex={tabIndex}
2728
>
2829
{i18n._t('LinkField.ADD_LINK', 'Add Link')}
2930
</DropdownToggle>

0 commit comments

Comments
 (0)