Skip to content

Commit 41b73b1

Browse files
authored
[image_picker] Update documentation of maxDuration to reflect that it only applies to recording (flutter#11417)
Fixes flutter/flutter#83630 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent a87e262 commit 41b73b1

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

packages/image_picker/image_picker/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1-
## NEXT
1+
## 1.2.2
22

3+
* Clarifies that `maxDuration` only applies to video recording and not gallery selection.
34
* Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.
45
* Updates README to reflect currently supported OS versions for the latest
56
versions of the endorsed platform implementations.
67
* Applications built with older versions of Flutter will continue to
78
use compatible versions of the platform implementations.
89

10+
911
## 1.2.1
1012

1113
* Fixes README description of plugin suggesting that only Android and iOS is supported.

packages/image_picker/image_picker/lib/image_picker.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,8 @@ class ImagePicker {
270270
/// The [source] argument controls where the video comes from. This can
271271
/// be either [ImageSource.camera] or [ImageSource.gallery].
272272
///
273-
/// The [maxDuration] argument specifies the maximum duration of the captured video. If no [maxDuration] is specified,
274-
/// the maximum duration will be infinite.
273+
/// The [maxDuration] argument specifies the maximum duration of the captured video when recording from the camera ([ImageSource.camera]),
274+
/// and is ignored for [ImageSource.gallery]. If no [maxDuration] is specified, the maximum duration will be infinite.
275275
///
276276
/// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera].
277277
/// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device.

packages/image_picker/image_picker/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for selecting images from the Android and iOS image
33
library, and taking new pictures with the camera.
44
repository: https://github.com/flutter/packages/tree/main/packages/image_picker/image_picker
55
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
6-
version: 1.2.1
6+
version: 1.2.2
77

88
environment:
99
sdk: ^3.9.0

0 commit comments

Comments
 (0)