rewrite linter config / skip vendor lint checks

Author: credativ-marco

.golangci.yml

@@ -1,77 +1,67 @@
-# This file contains all available configuration options
-# with their default values.
-
-# options for analysis running
+version: "2"
 run:
-  # default concurrency is a available CPU number
   concurrency: 16
-
-  # timeout for analysis, e.g. 30s, 5m, default is 1m
-  timeout: 5m
-
-  # exit code when at least one issue was found, default is 1
   issues-exit-code: 1
-
-  # include test files or not, default is true
   tests: true
-
-  # list of build tags, all linters use it. Default is empty list.
-  build-tags:
-
-  # which dirs to skip: they won't be analyzed;
-  # can use regexp here: generated.*, regexp is applied on full path;
-  # default value is empty list, but next dirs are always skipped independently
-  # from this option's value:
-  #   	vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-  skip-dirs:
-    - win_eventlog$
-  # which files to skip: they will be analyzed, but issues from them
-  # won't be reported. Default value is empty list, but there is
-  # no need to include all autogenerated files, we confidently recognize
-  # autogenerated files. If it's not please let us know.
-  skip-files:
-    # exclude autogenerated files
-    - pkg/ingester/checkpoint.pb.go
-    - pkg/logproto/logproto.pb.go
-    - pkg/logql/expr.y.go
-    - pkg/logql/log/jsonexpr/jsonexpr.y.go
-    - pkg/logql/stats/stats.pb.go
-    - pkg/querier/queryrange/queryrange.pb.go
-    - pkg/valitail/server/ui/assets_vfsdata.go
-# output configuration options
 output:
-  # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number"
-  format: colored-line-number
-
-  # print lines of code with issue, default is true
-  print-issued-lines: true
-
-  # print linter name in the end of issue text, default is true
-  print-linter-name: true
-
-linters-settings:
-  goimports:
-    local-prefixes: github.com/credativ/vali/pkg
-
+  formats:
+    text:
+      path: stdout
+      print-linter-name: true
+      print-issued-lines: true
 linters:
   enable:
-    - errcheck
     - goconst
-    - gofmt
-    - goimports
-    - gosimple
-    - ineffassign
-    - megacheck
     - misspell
     - unconvert
     - unparam
-    - govet
-    - unused # new from here.
-    - typecheck
-
-issues:
-  exclude:
-    - Error return value of .*log\.Logger\)\.Log\x60 is not checked
-    - Error return value of .*.Log.* is not checked
-    - '"io/ioutil" has been deprecated'
-    - rand.Seed has been deprecated
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - path: (.+)\.go$
+        text: Error return value of .*log\.Logger\)\.Log\x60 is not checked
+      - path: (.+)\.go$
+        text: Error return value of .*.Log.* is not checked
+      - path: (.+)\.go$
+        text: '"io/ioutil" has been deprecated'
+      - path: (.+)\.go$
+        text: rand.Seed has been deprecated
+    paths:
+      - pkg/ingester/checkpoint.pb.go
+      - pkg/logproto/logproto.pb.go
+      - pkg/logql/expr.y.go
+      - pkg/logql/log/jsonexpr/jsonexpr.y.go
+      - pkg/logql/stats/stats.pb.go
+      - pkg/querier/queryrange/queryrange.pb.go
+      - pkg/valitail/server/ui/assets_vfsdata.go
+      - win_eventlog$
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/credativ/vali/pkg
+  exclusions:
+    generated: lax
+    paths:
+      - pkg/ingester/checkpoint.pb.go
+      - pkg/logproto/logproto.pb.go
+      - pkg/logql/expr.y.go
+      - pkg/logql/log/jsonexpr/jsonexpr.y.go
+      - pkg/logql/stats/stats.pb.go
+      - pkg/querier/queryrange/queryrange.pb.go
+      - pkg/valitail/server/ui/assets_vfsdata.go
+      - win_eventlog$
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -244,7 +244,7 @@ publish: dist
 ########
 
 lint:
-	GOGC=10 golangci-lint run -v --timeout 60m $(GOLANGCI_ARG)
+	GOGC=10 golangci-lint run -v --timeout 60m
 	faillint -paths "sync/atomic=go.uber.org/atomic" ./...
 
 ########