buildtest: remove --long-running/--parallel-algorithm flags that break benchmark test discovery

[credfeto]

Prompt (verbatim, from live chat)

can you also apply this change to the buildtest in scripts?

Context: while fixing credfeto/credfeto-global-pre-commit#189 (per-project benchmark dotnet test invocation passing --long-running 10 --parallel-algorithm sequential, which a real benchmark project's test host rejects as invalid arguments, exit code 5, "Zero tests ran"), the human asked for the equivalent flag removal in this repo's development/buildtest, which has its own (older, single-phase) dotnet test invocation with the same two flags.

Relationship to #679

#679 is already open in this repo for a related but broader problem: --parallel-algorithm aggressive racing benchmark assemblies against regular unit tests causes OutOfMemoryException. Its pending Implementation Plan comment (from a different agent identity) proposes a larger refactor: making benchmark exclusion the default, fixing the --no-benchmmarks/--no-integratopn flag typos, and fixing the broken TEST_BENCHMARKS=--filter-not-namespace ... unquoted assignment.

This issue is intentionally narrower: it only removes the two flags shown to cause outright argument-rejection failures (confirmed by direct reproduction against FunFair.Ethereum.DataTypes.Benchmark.Tests), matching the fix already applied in credfeto-global-pre-commit#189. It does not attempt the broader refactor or typo fixes tracked in #679's pending plan, to avoid conflicting with that in-flight work.

Proposed fix

In development/buildtest, remove --long-running 10 and --parallel-algorithm aggressive from the single dotnet test invocation (current lines 169 and 172).

Evidence

Direct reproduction in funfair-server-ethereum: running the equivalent dotnet test invocation without --long-running 10 --parallel-algorithm sequential (the analogous flags in the two-phase credfeto-global-pre-commit version) passed 4/4 tests in 4m20s; with them, the same project produced exit code 5 ("Zero tests ran") in under a second.

[credfeto]

Implementation Plan

Files to change

• development/buildtest: remove --long-running 10 (line 169) and --parallel-algorithm aggressive (line 172) from the single dotnet test invocation.

Approach

Mirrors the fix in credfeto-global-pre-commit#189. The unconditional dotnet test call in this script passes --long-running 10 --parallel-algorithm aggressive, and by default (unless -b/--no-benchmmarks is passed) benchmark test assemblies run within that same call. At least one real benchmark project rejects these as invalid command-line arguments (exit code 5, "Zero tests ran" in well under a second) rather than actually running. Removing both flags fixes discovery for that project. This also happens to remove the literal --parallel-algorithm aggressive value that #679 already identifies as the root cause of the OOM racing problem, so it is a net improvement there too, though it does not attempt #679's broader refactor (typo fixes, default-exclude-benchmarks behaviour) - that stays with the pending plan already posted on #679.

Test strategy

This repo has no automated test suite covering development/buildtest directly (it's a POSIX shell script invoked in consuming repos). Will run shellcheck --shell=sh and checkbashisms against the modified file to confirm no new lint issues, consistent with this repo's existing pre-commit checks.

Assumptions

• Scope is limited to the two flags shown to break argument parsing, not the other pre-existing issues already tracked on buildtest: aggressive parallel algorithm causes OOM when benchmark tests run #679's plan.

Open questions

None, ready to proceed pending approval.

[credfeto]

Approved via live chat: "can you also apply this change to the buildtest in scripts?" (the requested change is the flag removal just discussed and approved for credfeto-global-pre-commit#189)

[credfeto]

Scope expanded per live chat request: "can you do the same split for the tests that we have in the pre-commit repo in the buildtest so it will do unit tests then any benchmarks if there are any" - confirmed as "port full split to scripts repo" via follow-up clarifying question.

This goes beyond the flag-removal already merged in this PR: development/buildtest now mirrors credfeto-global-pre-commit's two-phase design - the main run always excludes benchmark test projects (keeping --long-running/--parallel-algorithm aggressive, safe now that benchmarks are not mixed in), and a separate step runs any benchmark projects found individually, one dotnet test per project, without those two flags.

Also fixed the TEST_BENCHMARKS variable's broken unquoted assignment (-b/--no-benchmmarks flag) as part of this change, since it is now load-bearing for skipping the new benchmark phase - this was previously a no-op due to the assignment bug.

Added a comment in the script pointing back to credfeto-global-pre-commit's src/scripts/buildtest as the source of truth for this design, per request.