Skip to content

Commit 26d2303

Browse files
add new acl fields to all entities (unitycatalog#491)
**PR Checklist** - [ x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Add the `owner` `created_by` and `updated_by` fields to all other entities (models already has them from previous PR). If the fields are populated, they will display in the details sidebar of each entity. Also, removing non-functional "add/edit description" button from version details page (missed this straggler in previous PR).
1 parent 67afede commit 26d2303

7 files changed

+20
-2
lines changed

ui/src/hooks/catalog.tsx

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ export interface CatalogInterface {
77
comment: string;
88
created_at: number;
99
updated_at: number | null;
10+
owner: string | null;
11+
created_by: string | null;
12+
updated_by: string | null;
1013
}
1114

1215
interface ListCatalogsResponse {

ui/src/hooks/functions.tsx

+3
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ export interface FunctionInterface {
1616
routine_definition: string;
1717
created_at: number;
1818
updated_at: number | null;
19+
owner: string | null;
20+
created_by: string | null;
21+
updated_by: string | null;
1922
}
2023
interface ListFunctionsResponse {
2124
functions: FunctionInterface[];

ui/src/hooks/models.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export interface ModelInterface {
99
comment: string;
1010
full_name: string;
1111
created_at: number;
12-
created_by: string;
12+
created_by: string | null;
1313
updated_at: number | null;
1414
updated_by: string | null;
1515
registered_model_id: string;

ui/src/hooks/schemas.tsx

+3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ export interface SchemaInterface {
1313
comment: string;
1414
created_at: number;
1515
updated_at: number | null;
16+
owner: string | null;
17+
created_by: string | null;
18+
updated_by: string | null;
1619
}
1720
interface ListSchemasResponse {
1821
schemas: SchemaInterface[];

ui/src/hooks/tables.tsx

+3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ export interface TableInterface {
2424
updated_at: number | null;
2525
data_source_format: string;
2626
columns: ColumnInterface[];
27+
owner: string | null;
28+
created_by: string | null;
29+
updated_by: string | null;
2730
}
2831
interface ListTablesResponse {
2932
tables: TableInterface[];

ui/src/hooks/volumes.tsx

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ export interface VolumeInterface {
1515
comment: string;
1616
created_at: number;
1717
updated_at: number | null;
18+
owner: string | null;
19+
created_by: string | null;
20+
updated_by: string | null;
1821
}
1922

2023
interface ListVolumesResponse {

ui/src/pages/ModelVersionDetails.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,10 @@ export default function ModelVersionDetails() {
9696
>
9797
<DetailsLayout.Content>
9898
<Flex vertical gap={60}>
99-
<DescriptionBox comment={data?.comment} />
99+
<div>
100+
<Typography.Title level={5}>Description</Typography.Title>
101+
<Typography.Text type="secondary">{data?.comment}</Typography.Text>
102+
</div>
100103
<div>
101104
<Typography.Title level={5} style={{ marginBottom: 16 }}>
102105
Version details

0 commit comments

Comments
 (0)