Fix #78 reverse logic in version detection so that default else will result in latest code

creecros · creecros · commit 9cace1043e70 · 2023-03-30T15:57:50.000Z
diff --git a/Plugin.php b/Plugin.php
@@ -54,14 +54,14 @@ public function initialize()
         }
         $clean_appversion = preg_replace('/\s+/', '', $applications_version);
 
-        if (version_compare($clean_appversion, '1.2.5', '>')) {
+        if (version_compare($clean_appversion, '1.2.5', '<')) {
             if (file_exists('plugins/MetaMagik')) {
                 $this->container['taskFinderModel'] = $this->container->factory(function ($c) {
-                    return new NewMetaMagikSubquery($c);
+                    return new OldMetaMagikSubquery($c);
                 });
             } else {
                 $this->container['taskFinderModel'] = $this->container->factory(function ($c) {
-                    return new NewTaskFinderModel($c);
+                    return new OldTaskFinderModel($c);
                 });
             }
             $this->container['taskDuplicationModel'] = $this->container->factory(function ($c) {
@@ -79,11 +79,11 @@ public function initialize()
         } else {
             if (file_exists('plugins/MetaMagik')) {
                 $this->container['taskFinderModel'] = $this->container->factory(function ($c) {
-                    return new OldMetaMagikSubquery($c);
+                    return new NewMetaMagikSubquery($c);
                 });
             } else {
                 $this->container['taskFinderModel'] = $this->container->factory(function ($c) {
-                    return new OldTaskFinderModel($c);
+                    return new NewTaskFinderModel($c);
                 });
             }
             $this->container['taskDuplicationModel'] = $this->container->factory(function ($c) {
@@ -202,7 +202,7 @@ public function getPluginAuthor()
     }
     public function getPluginVersion()
     {
-        return '1.8.0';
+        return '1.8.1';
     }
     public function getPluginHomepage()
     {

Original file line number	Diff line number	Diff line change
`@@ -54,14 +54,14 @@ public function initialize()`
`54`	`54`	`}`
`55`	`55`	`$clean_appversion = preg_replace('/\s+/', '', $applications_version);`
`56`	`56`
`57`		`- if (version_compare($clean_appversion, '1.2.5', '>')) {`
	`57`	`+ if (version_compare($clean_appversion, '1.2.5', '<')) {`
`58`	`58`	`if (file_exists('plugins/MetaMagik')) {`
`59`	`59`	`$this->container['taskFinderModel'] = $this->container->factory(function ($c) {`
`60`		`- return new NewMetaMagikSubquery($c);`
	`60`	`+ return new OldMetaMagikSubquery($c);`
`61`	`61`	`});`
`62`	`62`	`} else {`
`63`	`63`	`$this->container['taskFinderModel'] = $this->container->factory(function ($c) {`
`64`		`- return new NewTaskFinderModel($c);`
	`64`	`+ return new OldTaskFinderModel($c);`
`65`	`65`	`});`
`66`	`66`	`}`
`67`	`67`	`$this->container['taskDuplicationModel'] = $this->container->factory(function ($c) {`
`@@ -79,11 +79,11 @@ public function initialize()`
`79`	`79`	`} else {`
`80`	`80`	`if (file_exists('plugins/MetaMagik')) {`
`81`	`81`	`$this->container['taskFinderModel'] = $this->container->factory(function ($c) {`
`82`		`- return new OldMetaMagikSubquery($c);`
	`82`	`+ return new NewMetaMagikSubquery($c);`
`83`	`83`	`});`
`84`	`84`	`} else {`
`85`	`85`	`$this->container['taskFinderModel'] = $this->container->factory(function ($c) {`
`86`		`- return new OldTaskFinderModel($c);`
	`86`	`+ return new NewTaskFinderModel($c);`
`87`	`87`	`});`
`88`	`88`	`}`
`89`	`89`	`$this->container['taskDuplicationModel'] = $this->container->factory(function ($c) {`
`@@ -202,7 +202,7 @@ public function getPluginAuthor()`
`202`	`202`	`}`
`203`	`203`	`public function getPluginVersion()`
`204`	`204`	`{`
`205`		`- return '1.8.0';`
	`205`	`+ return '1.8.1';`
`206`	`206`	`}`
`207`	`207`	`public function getPluginHomepage()`
`208`	`208`	`{`