better message

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Author: crenshaw-dev

resource_customizations/promoter.argoproj.io/ChangeTransferPolicy/health.lua

@@ -28,7 +28,7 @@ if obj.metadata.deletionTimestamp then
         {
             ["changetransferpolicy.promoter.argoproj.io/finalizer"] = {
                 wait = "Waiting to clear related PullRequest finalizers and finish cleanup before this policy is removed.",
-                risk = "the policy can disappear while related PullRequests are still terminating or inconsistent with Git.",
+                risk = "The 'changetransferpolicy.promoter.argoproj.io/pullrequest-finalizer' finalizer may not be cleaned up from PullRequests owned by this ChangeTransferPolicy.",
             },
         }
     )

resource_customizations/promoter.argoproj.io/ChangeTransferPolicy/health_test.yaml

@@ -5,7 +5,7 @@ tests:
   inputPath: testdata/no-status.yaml
 - healthStatus:
     status: Progressing
-    message: 'Change transfer policy is being deleted. changetransferpolicy.promoter.argoproj.io/finalizer: Waiting to clear related PullRequest finalizers and finish cleanup before this policy is removed. Risk if removed manually: the policy can disappear while related PullRequests are still terminating or inconsistent with Git.'
+    message: "Change transfer policy is being deleted. changetransferpolicy.promoter.argoproj.io/finalizer: Waiting to clear related PullRequest finalizers and finish cleanup before this policy is removed. Risk if removed manually: The 'changetransferpolicy.promoter.argoproj.io/pullrequest-finalizer' finalizer may not be cleaned up from PullRequests owned by this ChangeTransferPolicy."
   inputPath: testdata/deleting.yaml
 - healthStatus:
     status: Progressing