Skip to content

Commit 20008c2

Browse files
committed
Remove ref to CEF's OnBeforeNavigation removed as part of chrome upgrade, ref #70
1 parent fa16b26 commit 20008c2

File tree

2 files changed

+0
-34
lines changed

2 files changed

+0
-34
lines changed

src/cef/cef_app_handler.cc

-13
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,6 @@ namespace doogie {
66

77
CefAppHandler::CefAppHandler() {}
88

9-
bool CefAppHandler::OnBeforeNavigation(
10-
CefRefPtr<CefBrowser> browser,
11-
CefRefPtr<CefFrame> frame,
12-
CefRefPtr<CefRequest> request,
13-
CefRenderProcessHandler::NavigationType navigation_type,
14-
bool is_redirect) {
15-
if (before_nav_callback_) {
16-
return before_nav_callback_(browser, frame, request,
17-
navigation_type, is_redirect);
18-
}
19-
return false;
20-
}
21-
229
void CefAppHandler::OnContextCreated(CefRefPtr<CefBrowser> browser,
2310
CefRefPtr<CefFrame> frame,
2411
CefRefPtr<CefV8Context> context) {

src/cef/cef_app_handler.h

-21
Original file line numberDiff line numberDiff line change
@@ -28,22 +28,6 @@ class CefAppHandler :
2828
}
2929

3030
// Render process handler overrides...
31-
bool OnBeforeNavigation(
32-
CefRefPtr<CefBrowser> browser,
33-
CefRefPtr<CefFrame> frame,
34-
CefRefPtr<CefRequest> request,
35-
CefRenderProcessHandler::NavigationType navigation_type,
36-
bool is_redirect) override;
37-
38-
void SetBeforeNavCallback(
39-
std::function<bool(CefRefPtr<CefBrowser>,
40-
CefRefPtr<CefFrame>,
41-
CefRefPtr<CefRequest>,
42-
CefRenderProcessHandler::NavigationType,
43-
bool)> before_nav_callback) {
44-
before_nav_callback_ = before_nav_callback;
45-
}
46-
4731
void OnContextCreated(CefRefPtr<CefBrowser> browser,
4832
CefRefPtr<CefFrame> frame,
4933
CefRefPtr<CefV8Context> context) override;
@@ -52,11 +36,6 @@ class CefAppHandler :
5236

5337
private:
5438
CosmeticBlocker blocker_;
55-
std::function<bool(CefRefPtr<CefBrowser>,
56-
CefRefPtr<CefFrame>,
57-
CefRefPtr<CefRequest>,
58-
CefRenderProcessHandler::NavigationType,
59-
bool)> before_nav_callback_;
6039

6140
IMPLEMENT_REFCOUNTING(CefAppHandler)
6241
};

0 commit comments

Comments
 (0)