From c10665c897fde911624191d4b11ac0bfb557fe5d Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Wed, 12 Feb 2025 20:02:39 +0000 Subject: [PATCH] refactor: Improve feedback message formatting - Use i18n for feedback message formatting - Enhance method documentation - Improve code organization Co-Authored-By: Joe Moura --- src/crewai/agents/crew_agent_executor.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/crewai/agents/crew_agent_executor.py b/src/crewai/agents/crew_agent_executor.py index 6670ead29a..e950195137 100644 --- a/src/crewai/agents/crew_agent_executor.py +++ b/src/crewai/agents/crew_agent_executor.py @@ -574,6 +574,9 @@ def _handle_regular_feedback( ) -> AgentFinish: """Process feedback for regular use with potential multiple iterations. + This method handles the iterative feedback process where the agent continues + to improve its answer based on user feedback until no more changes are needed. + Args: current_answer (AgentFinish): The current answer from the agent initial_feedback (str): The initial feedback from the user @@ -582,7 +585,7 @@ def _handle_regular_feedback( AgentFinish: The final answer after processing all feedback iterations Raises: - FeedbackProcessingError: If feedback processing fails + FeedbackProcessingError: If feedback processing or validation fails """ try: feedback = initial_feedback @@ -590,12 +593,10 @@ def _handle_regular_feedback( while self.ask_for_human_input: # Add feedback message with user role using standard formatter - self.messages.append(self._format_msg( - f"Feedback: {feedback}", - role="user" - )) + feedback_msg = self._i18n.slice("feedback_message").format(feedback=feedback) + self.messages.append(self._format_msg(feedback_msg, role="user")) + response = self._get_llm_feedback_response(feedback) - if not self._feedback_requires_changes(response): self.ask_for_human_input = False else: