Remove sitemap_generator gem and usage (#4156)

Cleanup following:

- #4155
- #4060

# Summary

- remove `sitemap_generator` config initializer 
- remove `sitemap_generator` in `Procfile` and a test
- remove `sitemap_generator` gem
- make xml/txt formats explicit in the routes (`curl .../sitemap.xml`
was getting the `.txt` version mistakenly)
- remove duplicate `/tce` URL in both sitemaps

Author: veganstraightedge

Gemfile

@@ -15,7 +15,6 @@ gem 'puma'
 gem 'autoprefixer-rails'
 gem 'bootstrap'
 gem 'sassc-rails'
-gem 'sitemap_generator' # for generating a compliant xml sitemap
 gem 'uglifier'
 
 # Javascript / Hotwire

Gemfile.lock

@@ -472,8 +472,6 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    sitemap_generator (6.3.0)
-      builder (~> 3.0)
     smart_properties (1.17.0)
     sorbet-runtime (0.5.11694)
     sprockets (4.2.1)
@@ -584,7 +582,6 @@ DEPENDENCIES
   selenium-webdriver
   sidekiq (< 8)
   simplecov
-  sitemap_generator
   squasher
   stackprof
   sterile

Procfile

@@ -1,3 +1,3 @@
-release: bundle exec rake db:migrate sitemap:refresh
+release: bundle exec rake db:migrate
 web: bundle exec puma -C config/puma.rb
 worker: RAILS_MAX_THREADS=${SIDEKIQ_RAILS_MAX_THREADS} bundle exec sidekiq -q default -q mailers -q active_storage_analysis -q active_storage_purge

app/views/sitemap/show.text.erb

@@ -42,8 +42,6 @@
 <% end %>
 <%# %>
 <%# To Change Everything (TCE) %>
-<%= to_change_everything_url %>
-<%# %>
 <% @to_change_everything_languages.each do |tce_language| %>
 <%= to_change_everything_url(lang: tce_language) %>
 <%= [to_change_everything_url(lang: tce_language), '/get'].join %>

app/views/sitemap/show.xml.erb

@@ -54,8 +54,6 @@
   <% end %>
 
   <%# To Change Everything (TCE) %>
-  <%= render 'sitemap/url', loc: to_change_everything_url, lastmod: @last_modified %>
-
   <% @to_change_everything_languages.each do |tce_language| %>
     <%= render 'sitemap/url', loc: to_change_everything_url(lang: tce_language), lastmod: @last_modified %>
     <%= render 'sitemap/url', loc: [to_change_everything_url(lang: tce_language), '/get'].join, lastmod: @last_modified %>

config/routes.rb

@@ -4,8 +4,8 @@
   # sitemaps
   # xml: for robots/search engines
   # txt: for humans/archivers
-  get 'sitemap.xml', to: 'sitemap#show', as: :sitemap
-  get 'sitemap.txt', to: 'sitemap#show', as: :sitemap_txt
+  get 'sitemap.xml', to: 'sitemap#show', defaults: { format: 'xml' }, as: :sitemap
+  get 'sitemap.txt', to: 'sitemap#show', defaults: { format: 'txt' }, as: :sitemap_txt
 
   # TODO: After switching the site auth to Devise, enable this auth protected route
   # # Sidekiq admin interface to monitor background jobs

config/sitemap.rb

@@ -16,15 +16,10 @@
   end
 
   it 'does not strip .xml extension from sitemap.xml' do
-    # TODO: update this test when we remove sitemap_generator gem and scheduled jobs
-    Rake::Task['sitemap:refresh:no_ping'].invoke
-
     get 'http://example.com/sitemap.xml'
 
     expect(response).to have_http_status(:ok)
     expect(response.header['Location']).to be_nil
     expect(response.body).not_to be_empty
-
-    Rake::Task['sitemap:clean'].invoke
   end
 end