Add some missing URLs to sitemaps (#4244)

- `articles#show` as `.markdown` 
- months of the years `/2025/01`, `/2024/12`, ...
- contradictionary definitions
- SSfWD 
-

Author: veganstraightedge

.rubocop.yml

@@ -11,17 +11,17 @@ require:
 AllCops:
   NewCops: enable
   Exclude:
-    - 'db/schema.rb'
-    - 'db/migrate/20230628052836_init_schema.rb'
-    - 'vendor/**/*'
+    - "db/schema.rb"
+    - "db/migrate/20230628052836_init_schema.rb"
+    - "vendor/**/*"
 
 Layout/HashAlignment:
   EnforcedHashRocketStyle: table
   EnforcedColonStyle: table
 
 Layout/LineLength:
   Exclude:
-    - 'db/**/*'
+    - "db/**/*"
 
 # This is too aggressive with our use of Seattle.rb style lack of parens on method calls
 # E.g., return redirect_to [:articles]
@@ -30,23 +30,23 @@ Layout/SpaceBeforeBrackets:
   Enabled: false
 
 Metrics/AbcSize:
-  Max: 74
+  Max: 80
 
 Metrics/BlockLength:
   Max: 99
   Exclude:
-    - 'config/routes.rb'
+    - "config/routes.rb"
 
 Metrics/ClassLength:
-  Max: 145
+  Max: 180
 
 Metrics/CyclomaticComplexity:
   Max: 13
 
 Metrics/MethodLength:
-  Max: 31
+  Max: 40
   Exclude:
-    - 'db/migrate/*'
+    - "db/migrate/*"
 
 Metrics/ModuleLength:
   Max: 116
@@ -68,29 +68,29 @@ Rails/EnvironmentVariableAccess:
 # Using `puts` is allowed in these files
 Rails/Output:
   Exclude:
-    - 'app/lib/code_archiver.rb'
-    - 'db/seeds.rb'
+    - "app/lib/code_archiver.rb"
+    - "db/seeds.rb"
 
 Rails/TimeZone:
   Exclude:
-    - 'script/*'
+    - "script/*"
 
 RSpec/DescribeClass:
   Exclude:
-    - 'spec/system/*'
+    - "spec/system/*"
 
 RSpec/ExampleLength:
   Max: 14
   Exclude:
-    - 'spec/system/*'
+    - "spec/system/*"
 
 RSpec/MessageSpies:
   Enabled: false
 
 RSpec/MultipleExpectations:
   Max: 5
   Exclude:
-    - 'spec/system/*'
+    - "spec/system/*"
 
 Style/AsciiComments:
   Enabled: false
@@ -106,7 +106,7 @@ Style/MethodDefParentheses:
 
 Style/MixinUsage:
   Exclude:
-    - 'script/*'
+    - "script/*"
 
 Style/RedundantFetchBlock:
   Enabled: false

app/controllers/sitemap_controller.rb

@@ -10,7 +10,6 @@ class SitemapController < ApplicationController
     kickstarter/2017
     library
     start
-    steal-something-from-work-day
     store
     tce
     tools
@@ -24,84 +23,219 @@ class SitemapController < ApplicationController
   ].flatten.freeze
 
   def show
-    @latest_article = Article.published.english.first
-    @last_modified  = @latest_article&.updated_at || Time.current
-    @urls           = []
+    set_latest_article
+    set_last_modified
 
     # articles feed, for all languages with articles
-    @localized_feeds = Locale.unscoped.order(name_in_english: :asc)
+    set_localized_feeds
 
     # categories
-    @categories = Category.all
+    set_categories
+
+    # tags
+    set_tags
 
     # articles
-    @articles = live_published_articles
+    set_articles
 
     # articles by year
-    @article_years = (1996..Time.zone.today.year).to_a
+    set_article_years
 
     # static-ish pages
-    @static_paths = STATIC_PATHS
+    set_static_paths
 
     # To Change Everything (TCE)
-    @to_change_everything_languages = TO_CHANGE_EVERYTHING_LANGUAGES
+    set_to_change_everything_languages
+
+    # Steal Something from Work Day (SSfWD)
+    set_steal_something_from_work_day_urls
 
     # languages
-    @locales = languages
+    set_locales
 
     # tools
     # books
+    set_books
+    set_books_last_modified
+    # contradictionary definitions
+    set_definitions
+    set_definitions_last_modified
+    # logos
+    set_logos
+    set_logos_last_modified
+    # posters
+    set_posters
+    set_posters_last_modified
+    # stickers
+    set_stickers
+    set_stickers_last_modified
+    # videos
+    set_videos
+    set_videos_last_modified
+    # zines
+    set_zines
+    set_zines_last_modified
+    # journals / issues
+    set_journals
+    set_journals_last_modified
+    set_issues
+    set_issues_last_modified
+    # podcasts / episodes
+    set_podcasts
+    set_podcasts_last_modified
+    set_episodes
+    set_episodes_last_modified
+  end
+
+  private
+
+  def set_latest_article
+    @latest_article = Article.published.english.first
+  end
+
+  def set_last_modified
+    @last_modified  = @latest_article&.updated_at || Time.current
+  end
+
+  # articles feed, for all languages with articles
+  def set_localized_feeds
+    @localized_feeds = Locale.unscoped.order(name_in_english: :asc)
+  end
+
+  def set_categories
+    @categories = Category.all
+  end
+
+  def set_tags
+    @tags = Tag.all
+  end
+
+  def set_articles
+    @articles =
+      Rails.cache.fetch([:sitemap, @latest_article, :live_published_articles], expires_in: 12.hours) do
+        Article.live.published.select(:id, :updated_at, :draft_code, :published_at, :publication_status, :slug)
+      end
+  end
+
+  def set_article_years
+    @article_years = (1996..Time.zone.today.year).to_a
+  end
+
+  def set_static_paths
+    @static_paths = STATIC_PATHS
+  end
+
+  def set_to_change_everything_languages
+    @to_change_everything_languages = TO_CHANGE_EVERYTHING_LANGUAGES
+  end
+
+  def set_steal_something_from_work_day_urls
+    @steal_something_from_work_day_urls = [steal_something_from_work_day_url]
+
+    ssfwd_locales = StealSomethingFromWorkDayController::STEAL_SOMETHING_FROM_WORK_DAY_LOCALES.keys - [:en]
+
+    ssfwd_locales.each do |ssfwd_locale|
+      @steal_something_from_work_day_urls << steal_something_from_work_day_url
+                                             .sub('http://',  "http://#{ssfwd_locale}.")
+                                             .sub('https://', "https://#{ssfwd_locale}.")
+    end
+  end
+
+  def set_locales
+    @locales = Locale.live.each do |locale|
+      unicode_url = language_url locale: locale.name.downcase.tr(' ', '-')
+      slug_url    = language_url locale: locale.slug.to_sym
+      english_url = language_url locale: locale.name_in_english.downcase.tr(' ', '-')
+
+      [unicode_url, slug_url, english_url].uniq
+    end
+  end
+
+  def set_books
     @books = Book.published.live
+  end
 
-    # logos
+  def set_books_last_modified
+    @books_last_modified = @books.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
+
+  def set_logos
     @logos = Logo.published.live
+  end
 
-    # posters
+  def set_logos_last_modified
+    @logos_last_modified = @logos.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
+
+  def set_posters
     @posters = Poster.published.live
+  end
 
-    # stickers
+  def set_posters_last_modified
+    @posters_last_modified = @posters.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
+
+  def set_stickers
     @stickers = Sticker.published.live
+  end
 
-    # videos
+  def set_stickers_last_modified
+    @stickers_last_modified = @stickers.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
+
+  def set_videos
     @videos = Video.published.live
+  end
 
-    # zines
+  def set_videos_last_modified
+    @videos_last_modified = @videos.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
+
+  def set_zines
     @zines = Zine.published.live
+  end
 
-    # journals / issues
+  def set_zines_last_modified
+    @zines_last_modified = @zines.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
+
+  def set_journals
     @journals = Journal.published.live
-    @issues   = Issue.published.live
+  end
 
-    # podcasts / episodes
-    @podcasts = Podcast.published.live
-    @episodes = Episode.published.live
+  def set_journals_last_modified
+    @journals_last_modified = @journals.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
 
-    # TODO: add @TOOL_latest_modified to each tool, used in view for lastmod: in url tag partial
-    # TODO: add contradictionary definitions pages to sitemap
-    # TODO: add tags index and show pages to sitemap
-    # TODO: add steal-something-from-work-day localized pages
+  def set_issues
+    @issues = Issue.published.live
   end
 
-  private
+  def set_issues_last_modified
+    @issues_last_modified = @issues.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
 
-  def sitemap_url = Data.define(:loc, :lastmod)
+  def set_podcasts
+    @podcasts = Podcast.published.live
+  end
 
-  # languages
-  def languages
-    Locale.live.each do |locale|
-      unicode_url = language_url locale: locale.name.downcase.tr(' ', '-')
-      slug_url    = language_url locale: locale.slug.to_sym
-      english_url = language_url locale: locale.name_in_english.downcase.tr(' ', '-')
+  def set_podcasts_last_modified
+    @podcasts_last_modified = @podcasts.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
 
-      [unicode_url, slug_url, english_url].uniq
-    end
+  def set_episodes
+    @episodes = Episode.published.live
   end
 
-  def live_published_articles
-    Rails.cache.fetch([:sitemap, @latest_article, :live_published_articles], expires_in: 12.hours) do
-      Article.live
-             .published
-             .select(:id, :updated_at, :draft_code, :published_at, :publication_status, :slug)
-    end
+  def set_episodes_last_modified
+    @episodes_last_modified = @episodes.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
+  end
+
+  def set_definitions
+    @definitions = Definition.live.published.group_by(&:filed_under)
+  end
+
+  def set_definitions_last_modified
+    @definitions_last_modified = Definition.unscoped.order(updated_at: :asc).first&.updated_at || Time.current
   end
 end

app/lib/code_archiver.rb

@@ -1,5 +1,5 @@
 class CodeArchiver
-  def run # rubocop:disable Metrics/MethodLength
+  def run
     # make all the directories
     system 'mkdir', '-p', articles_prefix
     system 'mkdir', '-p', pages_prefix