Skip to content

Commit 30504f7

Browse files
authored
Correct accessibility values (#219)
`aria-valuemin` is not where the current value should go, `aria-valuenow` is. This is causing problems where screen readers are reading out incorrect percentages as negative values. (see https://www.w3.org/TR/wai-aria-1.1/#progressbar for more info)
1 parent d755791 commit 30504f7

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/lib/round-progress/round-progress.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@ import {RoundProgressEase} from './round-progress.ease';
2323
styleUrls: ['./round-progress.component.css'],
2424
host: {
2525
role: 'progressbar',
26-
'[attr.aria-valuemin]': 'current',
26+
'[attr.aria-valuemin]': '0',
2727
'[attr.aria-valuemax]': 'max',
28+
'[attr.aria-valuenow]': 'current',
2829
'[style.width]': 'responsive ? "" : _getDiameter() + "px"',
2930
'[style.height]': '_getElementHeight()',
3031
'[style.padding-bottom]': '_getPaddingBottom()',

0 commit comments

Comments
 (0)