Updated axios & fixed tests & other quality fixes (#37)

* Update deps

* eslint

* Add `.idea`

* Update package-lock.json

* Small quality fixes

* Update

* sefinek24/cronitor-js

* @sefinek/cronitor

* Update

* Update GH workflows

* Use `Buffer.from`

* 2.3.5

* Replace to `cronitor`

* cronitorio/cronitor-js

* Quality fixes

* Add `.npmignore`

* Small fixes

* Update README.md

* Remove empty lines

* #37 (comment)

* Update tests

Author: sefinek

.eslintrc.js

@@ -0,0 +1,54 @@
+module.exports = {
+    'extends': [
+        'eslint:recommended',
+    ],
+    'env': {
+        'node': true,
+        'es2023': true,
+    },
+    'parserOptions': {
+        'ecmaVersion': 2023,
+    },
+    'rules': {
+        'arrow-spacing': ['warn', { 'before': true, 'after': true }],
+        'comma-dangle': ['error', 'always-multiline'],
+        'comma-spacing': 'error',
+        'comma-style': 'error',
+        'curly': ['error', 'multi-line', 'consistent'],
+        'dot-location': ['error', 'property'],
+        'handle-callback-err': 'off',
+        'indent': ['warn', 4],
+        'keyword-spacing': 'warn',
+        'max-nested-callbacks': ['error', { 'max': 4 }],
+        'max-statements-per-line': ['error', { 'max': 2 }],
+        'no-console': 'off',
+        'no-empty-function': 'error',
+        'no-floating-decimal': 'error',
+        'no-lonely-if': 'error',
+        'no-multi-spaces': 'warn',
+        'no-multiple-empty-lines': ['warn', { 'max': 4, 'maxEOF': 1, 'maxBOF': 0 }],
+        'no-shadow': ['error', { 'allow': ['err', 'resolve', 'reject'] }],
+        'no-trailing-spaces': ['warn'],
+        'no-var': 'error',
+        'object-curly-spacing': ['error', 'always'],
+        'prefer-const': 'error',
+        'quotes': ['warn', 'single'],
+        'semi': ['warn', 'always'],
+        'space-before-blocks': 'error',
+        'space-before-function-paren': ['error', {
+            'anonymous': 'never',
+            'named': 'never',
+            'asyncArrow': 'always',
+        }],
+        'space-in-parens': 'error',
+        'space-infix-ops': 'error',
+        'space-unary-ops': 'error',
+        'spaced-comment': 'warn',
+        'yoda': 'error',
+        'no-use-before-define': ['error', { 'functions': false, 'classes': true }],
+        'no-unused-vars': 'warn',
+        'wrap-regex': 'error',
+        'sort-vars': 'warn',
+        'no-unreachable': 'warn',
+    },
+};

.github/workflows/node.js.yml

@@ -1,27 +1,29 @@
-# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
-# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
-
-name: Tests
+name: Node.js CI
 
 on:
   push:
   pull_request:
 
 jobs:
-  build:
+  test:
 
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 14.x]
+        node-version: [16.x, 18.x, 20.x, 21.x]
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node-version }}
-    - run: npm ci
-    - run: npm run build --if-present
-    - run: npm test
+      - uses: actions/checkout@v4
+
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run tests
+        run: npm run test

.gitignore

@@ -1,5 +1,6 @@
+.idea
+.vscode
 .DS_Store
 node_modules
 npm-debug.log
 coverage
-.vscode

.npmignore

@@ -0,0 +1 @@
+.github

README.md

@@ -1,8 +1,8 @@
 # Cronitor Node Library
 
-![Tests](https://github.com/cronitorio/cronitor-js/workflows/Tests/badge.svg)
+![Tests](https://github.com/cronitorio/cronitor-js/workflows/Node.js%20CI/badge.svg)
 
-[Cronitor](https://cronitor.io/) provides end-to-end monitoring for background jobs, websites, APIs, and anything else that can send or receive an HTTP request. This library provides convenient access to the Cronitor API from applications written in Javascript. See our [API docs](https://cronitor.io/docs/api) for detailed references on configuring monitors and sending telemetry pings.
+[Cronitor](https://cronitor.io) provides end-to-end monitoring for background jobs, websites, APIs, and anything else that can send or receive an HTTP request. This library provides convenient access to the Cronitor API from applications written in Javascript. See our [API docs](https://cronitor.io/docs/api) for detailed references on configuring monitors and sending telemetry pings.
 
 In this guide:
 
@@ -34,7 +34,7 @@ cron.wraps(nodeCron);
 
 // the first parameter is now the key that Cronitor will use
 // to send telemetry events when the jobs runs, completes or fails
-cron.schedule('SendWelcomeEmail', '*/5 * * * *', function() {
+cron.schedule('SendWelcomeEmail', '*/5 * * * *', () => {
     console.log('Sending welcome email to new sign ups every five minutes.');
 });
 ```
@@ -46,7 +46,7 @@ Cronitor can wrap any function with telemetry pings.
 ```javascript
 const cronitor = require('cronitor')('cronitor_api_key');
 
-let asyncWorker = cronitor.wrap('background-worker', async function() {
+let asyncWorker = cronitor.wrap('background-worker', async () => {
     // do some async work
 });
 
@@ -68,7 +68,7 @@ event = new cronitor.Event('monitor-key');
 
 const app = Consumer.create({
   queueUrl: 'https://sqs.eu-west-1.amazonaws.com/account-id/queue-name',
-  pollingWaitTimeMs: 100 // duration to wait before repolling the queue (defaults to 0).
+  pollingWaitTimeMs: 100, // duration to wait before repolling the queue (defaults to 0).
   handleMessage: async (message) => {
     // do some work with `message`
   }
@@ -206,7 +206,7 @@ const uptimeMonitor = await cronitor.Monitor.put({
     schedule: 'every 45 seconds',
     request: {
         url: 'https://cronitor.io'
-    }
+    },
     assertions: [
         'response.code = 200',
         'response.time < 600ms'
@@ -227,7 +227,7 @@ monitor.delete() // destroy the monitor
 
 ## Package Configuration
 
-The package needs to be configured with your account's `API key`, which is available on the [account settings](https://cronitor.io/settings) page. You can also optionally specify an `api_version`, an `environment`, and a request `timeout`. 
+The package needs to be configured with your account's `API key`, which is available on the [account settings](https://cronitor.io/settings) page. You can also optionally specify an `api_version`, an `environment`, and a request `timeout`.
 
 These can also be supplied using the environment variables `CRONITOR_API_KEY`, `CRONITOR_API_VERSION`, `CRONITOR_ENVIRONMENT`, `CRONITOR_TIMEOUT`.
 

examples/event-example.js

@@ -1,37 +1,35 @@
-const axios = require('axios')
-const Parser = require('rss-parser')
-const cronitor = require('../lib/cronitor')('fakeApiKey')
-let parser = new Parser()
+const Parser = require('rss-parser');
+const cronitor = require('../lib/cronitor')('fakeApiKey');
+const parser = new Parser();
 
-const event = new cronitor.Event('monitor-key')
+const event = new cronitor.Event('monitor-key');
 
 async function init() {
-  let currStatus = status = await checkGithubStatus()
-  while(true) {
-    status = await checkGithubStatus()
-    if (currStatus != status) {
-      sendStatusAlert(status)
-      currStatus = status
-    } else {
-      console.log("no new incident")
+    let currStatus = status = await checkGithubStatus();
+    while (true) {
+        status = await checkGithubStatus();
+        if (currStatus !== status) {
+            await sendStatusAlert(status);
+            currStatus = status;
+        } else {
+            console.log('No new incident');
+        }
+
+        await sleep(1);
+        event.tick();
     }
-    await sleep(1)
-    event.tick()
-  }
-}; init()
+} init();
 
 async function checkGithubStatus() {
-  let feed = await parser.parseURL('https://www.githubstatus.com/history.rss')
-  return feed.items[0]['title']
+    const feed = await parser.parseURL('https://www.githubstatus.com/history.rss');
+    return feed.items[0]['title'];
 }
 
 function sleep(seconds) {
-  return new Promise(resolve => setTimeout(resolve, (seconds * 1000)));
+    return new Promise(resolve => setTimeout(resolve, (seconds * 1000)));
 }
 
 function sendStatusAlert(status) {
-  // simulate network call
-  return new Promise(resolve => setTimeout(resolve, 100)).then(() => console.log(`New Incident! ${status}`));
+    // simulate network call
+    return new Promise(resolve => setTimeout(resolve, 100)).then(() => console.log(`New Incident! ${status}`));
 }
-
-