Fix bug in inplace operations for units

Author: langmm

rapidjson

@@ -52,6 +52,8 @@ def test_str_multiply(self):
         y = units.Units("hr")
         z = x * y
         assert str(z) == "hr"
+        x *= y
+        assert x == z
 
     @pytest.mark.parametrize('u', [
         'invalid'

tests/test_units.py

@@ -546,6 +546,7 @@ static PyObject* do_units_op(PyObject* a, PyObject *b, BinaryOps op,
     PyObject* out;
     if (inplace) {
 	out = a;
+        Py_INCREF(out);
     } else {
 	out = (PyObject*) Units_Type.tp_alloc(&Units_Type, 0);
 	((UnitsObject*)out)->units = new Units();
@@ -568,9 +569,7 @@ static PyObject* do_units_op(PyObject* a, PyObject *b, BinaryOps op,
 	break;
     }
     default: {
-	if (!inplace) {
-	    Py_DECREF(out);
-	}
+        Py_DECREF(out);
 	PyErr_SetString(PyExc_NotImplementedError, "rapidjson.units.Units do not support this operation.");
 	return NULL;
     }